Universal/NoFQNTrueFalseNull: fix for changed tokenization in PHPCS 3.13.3 and 4.0 #375
+27
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP_CodeSniffer 3.13.3 + 3.13.4 and PHPCSUtils 1.1.2 have been released. This commit raises the minimum supported PHPCS/Utils versions for improved PHP 8.4 support. Note: while raising to 3.13.4 is not necessary from a functional point of view, 3.13.3 contains an issue which blocks the ability to run the tests, so we need 3.13.4 to safeguard the functionality of this external standard correctly. Ref: * https://github.com/PHPCSStandards/PHPCSUtils/releases/tag/1.1.2 * https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.13.3 * https://github.com/PHPCSStandards/PHP_CodeSniffer/releases/tag/3.13.4
….13.3 and 4.0 The tokenization of fully qualified `true`/`false`/`null` has been changed for both PHPCS 3.x (as of 3.13.3) as well as PHPCS 4.0. The new tokenization means we don't need to take these tokens being tokenized as `T_STRING` or `T_NAME_FULLY_QUALIFIED` into account anymore, as long as the minimum supported PHPCS version will be PHPCS 3.13.3. However, we now do need to verify that `T_TRUE`/`T_FALSE`/`T_NULL` tokens don't have a namespace separator included in their contents. This commit updates the sniff for these changes. Ref: * PHPCSStandards/PHP_CodeSniffer 1201 * PHPCSStandards/PHP_CodeSniffer 1206
jrfnl
deleted the
feature/universal-nofqntruefalsenull-fix-for-phpcs-3.13.3-4.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: raise the minimum supported PHPCS + PHPCSUtils versions
PHP_CodeSniffer 3.13.3 + 3.13.4 and PHPCSUtils 1.1.2 have been released.
This commit raises the minimum supported PHPCS/Utils versions for improved PHP 8.4 support.
Note: while raising to 3.13.4 is not necessary from a functional point of view, 3.13.3 contains an issue which blocks the ability to run the tests, so we need 3.13.4 to safeguard the functionality of this external standard correctly.
Ref:
Universal/NoFQNTrueFalseNull: fix for changed tokenization in PHPCS 3.13.3 and 4.0
The tokenization of fully qualified
true/false/nullhas been changed for both PHPCS 3.x (as of 3.13.3) as well as PHPCS 4.0.The new tokenization means we don't need to take these tokens being tokenized as
T_STRINGorT_NAME_FULLY_QUALIFIEDinto account anymore, as long as the minimum supported PHPCS version will be PHPCS 3.13.3.However, we now do need to verify that
T_TRUE/T_FALSE/T_NULLtokens don't have a namespace separator included in their contents.This commit updates the sniff for these changes.
Ref: