Skip to content

Fix out of bounds array access in folder memcards#4113

Merged
tadanokojin merged 1 commit intoPCSX2:masterfrom
Ziemas:foldermem_oob
Jan 7, 2021
Merged

Fix out of bounds array access in folder memcards#4113
tadanokojin merged 1 commit intoPCSX2:masterfrom
Ziemas:foldermem_oob

Conversation

@Ziemas
Copy link
Copy Markdown
Contributor

@Ziemas Ziemas commented Jan 7, 2021

Don't keep the DataClusterInUse bit when accessing the next cluster.

With this folder memcards work on 64bit, but I'm confused why they would have worked on 32bit in the first place.

fixes #3839

Copy link
Copy Markdown
Member

@GovanifY GovanifY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh god. That's bad. Needs to test but oh no.

@RedPanda4552 RedPanda4552 self-requested a review January 7, 2021 14:14
@tadanokojin tadanokojin merged commit 1f236ca into PCSX2:master Jan 7, 2021
@Ziemas Ziemas deleted the foldermem_oob branch February 10, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x86_64: FolderMemoryCard::AddFileEntryToMetadataQuickAccess: segmentation fault

5 participants