always log monitor task errors

lhoward · lhoward · commit f0985bd9dba7 · 2024-11-28T15:39:16.000+11:00
diff --git a/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift b/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift
@@ -341,13 +341,14 @@ extension Ocp1Connection {
   }
 
   func onMonitorError(id: Int, _ error: Error) async throws {
+    logger.trace("monitor task \(id) error: \(error)")
+
     if _connectionState.value != .notConnected {
       // don't update connection state if we were explicitly disconnected
       _updateConnectionState(error.ocp1ConnectionState)
     }
 
     if _automaticReconnect, error._isRecoverableConnectionError {
-      logger.trace("monitor task \(id) disconnecting: \(error)")
       try await _disconnectDeviceAfterConnectionFailure()
       Task.detached { try await self.reconnectDeviceWithBackoff() }
     }

Original file line number	Diff line number	Diff line change
`@@ -341,13 +341,14 @@ extension Ocp1Connection {`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`func onMonitorError(id: Int, _ error: Error) async throws {`
	`344`	`+ logger.trace("monitor task \(id) error: \(error)")`
	`345`	`+`
`344`	`346`	`if _connectionState.value != .notConnected {`
`345`	`347`	`// don't update connection state if we were explicitly disconnected`
`346`	`348`	`_updateConnectionState(error.ocp1ConnectionState)`
`347`	`349`	`}`
`348`	`350`
`349`	`351`	`if _automaticReconnect, error._isRecoverableConnectionError {`
`350`		`- logger.trace("monitor task \(id) disconnecting: \(error)")`
`351`	`352`	`try await _disconnectDeviceAfterConnectionFailure()`
`352`	`353`	`Task.detached { try await self.reconnectDeviceWithBackoff() }`
`353`	`354`	`}`