add reentrancy check to connect()

lhoward · lhoward · commit e257f31d638b · 2024-11-28T14:55:07.000+11:00
If already connecting or reconnecting when connect() is called, throw new
connectionAlreadyInProgress error.
diff --git a/Sources/SwiftOCA/OCF/Errors.swift b/Sources/SwiftOCA/OCF/Errors.swift
@@ -21,6 +21,7 @@ public enum Ocp1Error: Error, Equatable {
   case alreadySubscribedToEvent
   case arrayOrDataTooBig
   case bonjourRegistrationFailed
+  case connectionAlreadyInProgress
   case connectionTimeout
   case duplicateObject(OcaONo)
   case endpointAlreadyRegistered
diff --git a/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift b/Sources/SwiftOCA/OCP.1/Ocp1Connection+Connect.swift
@@ -185,6 +185,8 @@ extension Ocp1Connection {
   }
 
   public func connect() async throws {
+    guard !isConnecting else { throw Ocp1Error.connectionAlreadyInProgress }
+
     _updateConnectionState(.connecting)
 
     do {

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,8 @@ extension Ocp1Connection {`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`public func connect() async throws {`
	`188`	`+ guard !isConnecting else { throw Ocp1Error.connectionAlreadyInProgress }`
	`189`	`+`
`188`	`190`	`_updateConnectionState(.connecting)`
`189`	`191`
`190`	`192`	`do {`