-
Notifications
You must be signed in to change notification settings - Fork 90
Non-contract changes from Staking PR #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactored networkMap into getNetworkName
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
=======================================
Coverage 38.26% 38.26%
=======================================
Files 112 112
Lines 5331 5331
Branches 1412 1412
=======================================
Hits 2040 2040
Misses 3289 3289
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -78,6 +82,10 @@ const PLUME_ADMIN = "0x92A19381444A001d62cE67BaFF066fA1111d7202"; | |||
// Plume 2/8 multisig | |||
const PLUME_STRATEGIST = MULTICHAIN_STRATEGIST; | |||
|
|||
const HOODI_DEPLOYER = MAINNET_DEPLOYER; | |||
// Hoodi Relayer | |||
const HOODI_RELAYER = "0x419B6BdAE482f41b8B194515749F3A2Da26d583b"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already import addresses.js
in this file. Any reason not using the hoodi relayer from there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was following the precedent of the other addresses are set in hardhat.config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: