Skip to content

Non-contract changes from Staking PR #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2025
Merged

Non-contract changes from Staking PR #2618

merged 10 commits into from
Aug 22, 2025

Conversation

naddison36
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@naddison36 naddison36 changed the title Hoodi infrastructure and other non-contract changes Non-contract changes from Staking PR Aug 11, 2025
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.26%. Comparing base (b3b0ebb) to head (31e8a08).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2618   +/-   ##
=======================================
  Coverage   38.26%   38.26%           
=======================================
  Files         112      112           
  Lines        5331     5331           
  Branches     1412     1412           
=======================================
  Hits         2040     2040           
  Misses       3289     3289           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -78,6 +82,10 @@ const PLUME_ADMIN = "0x92A19381444A001d62cE67BaFF066fA1111d7202";
// Plume 2/8 multisig
const PLUME_STRATEGIST = MULTICHAIN_STRATEGIST;

const HOODI_DEPLOYER = MAINNET_DEPLOYER;
// Hoodi Relayer
const HOODI_RELAYER = "0x419B6BdAE482f41b8B194515749F3A2Da26d583b";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already import addresses.js in this file. Any reason not using the hoodi relayer from there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the precedent of the other addresses are set in hardhat.config.js

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naddison36 naddison36 merged commit a8be73b into master Aug 22, 2025
15 of 19 checks passed
@naddison36 naddison36 deleted the nicka/hoodi branch August 22, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants