fix deletion of week period & code simplifications #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larcorba
added
bug
larcorba
requested changes
Sep 10, 2021
There was a problem hiding this comment.
Let's put the new weekly partition format into a seperate pull request.
Testing will be done seperatly and I will create two new versions from the merges:
2.1 - Fixing the weekly partitioning bug
3.0 - New weekly partition format
Seems nicer than cherry picking it.
|
moved the timestamp fix to a separate branch, so github doesn't automatically combine the commits into the same pull request |
larcorba
added
testing
larcorba
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the missing handling 'week' periods when deleting partitions.
It also includes lots of simplifications in the code.