Skip to content

Add docker support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thiagomdiniz
Copy link
Contributor

I made some modifications to the Perl script referring to the logs and the database connection parameters to be able to work with environment variables inside the Docker container.

I also added a docker folder containing the files to run the container, a Dockerfile to build the container and a Zabbix template to monitor the execution of the partitioning routine.

Maybe you think the change is too big, but I hope I can help other members of the community.
Thanks in advance!

@larcorba
Copy link
Member

larcorba commented Jul 7, 2023

Hi @thiagomdiniz

Thanks a lot for adding your code to the repository for Docker instances. I haven't been able to do a full test on this yet, but I am trying to pick it up in the coming weeks to make this part of partitioning.

I did a quick run over, all seems well. Just need to test it out in various environments, making sure it all still works on non-docker as well :) Will update you a.s.a.p.

@larcorba larcorba added investigating Currently checking this issue testing Currently testing this labels Jul 7, 2023
@larcorba larcorba self-assigned this Jul 7, 2023
@larcorba larcorba merged commit 5f3e78e into OpensourceICTSolutions:main Jun 2, 2024
@larcorba
Copy link
Member

larcorba commented Jun 2, 2024

Sorry it took so long @thiagomdiniz but I've tested and included your Docker edits into the 6.0 release with Zabbix 7.0 support.

If there's any edits meanwhile feel free to open a pull request for it here! Docker support is now officially part of this version of the script :)

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog investigating Currently checking this issue testing Currently testing this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants