Add equal to Bytes.sol and update pragma to 0.8.24 in String dependencies#5726
Add equal to Bytes.sol and update pragma to 0.8.24 in String dependencies#5726Amxx merged 14 commits intoOpenZeppelin:masterfrom
equal to Bytes.sol and update pragma to 0.8.24 in String dependencies#5726Conversation
🦋 Changeset detectedLatest commit: cf297b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c89daf2 to
ef6cfba
Compare
|
Where is mcopy used ? the pragma checking scripts says Strings is fine in 0.8.20. |
The description is pretty clear about where's used: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5725/files#diff-e402541b45f70ec8d3de9b9f87542d9eb52920601ac011a340e723c5b4b9d659R136 I generally split the PRs because then they are too big to review, but then done individually lose context... |
|
So this PR changes all pragma, and increass the requirements on many file, to prepare for a change in the code that is NOT in this PR, and that we are not even sure of doing in the near future ? I would say no to that kind of change. I'd even consider not adding Strings.equal considering all the breaking pragma and the limited upside. |
equal to Bytes.sol and update pragma to 0.8.24 in String dependencies
|
Include the |
In #5725, we're moving the
equalfunction from Strings to Bytes.sol for convenience, that'd require updating the pragma of Strings's dependencies to 0.8.24 sincemcopyis needed.PR Checklist
npx changeset add)