Skip to content

feat: add configurable maximum dictation duration#505

Open
NathanSkene wants to merge 1 commit intoOpenWhispr:mainfrom
NathanSkene:pr/max-dictation-duration
Open

feat: add configurable maximum dictation duration#505
NathanSkene wants to merge 1 commit intoOpenWhispr:mainfrom
NathanSkene:pr/max-dictation-duration

Conversation

@NathanSkene
Copy link
Copy Markdown
Contributor

Summary

  • Adds a configurable maximum recording duration setting
  • Recording automatically stops when the limit is reached
  • Prevents accidentally long recordings that may fail transcription

Test plan

  • Set max duration in Settings
  • Start recording and wait for limit
  • Verify recording stops automatically at the configured duration
  • Verify transcription processes normally after auto-stop

…op warning

- Add maxDictationDurationSeconds numeric setting (default 5 min)
- Add auto-stop logic in DictationWidget with 60s amber warning
- Add duration selector UI in Privacy settings section
- Add translation keys for max dictation duration
- Change keepTranscriptionInClipboard default to true for better UX

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@NathanSkene
Copy link
Copy Markdown
Contributor Author

Manual validation update on macOS with the packaged installed app:

This feature passed validation after fixing a gap in the original implementation.

What I verified in the real installed app:

  • setting a max dictation duration causes recording to stop automatically at the configured limit
  • transcription still completes normally after the auto-stop

Important implementation note:

  • the original branch did not wire max-duration enforcement into the real hotkey/floating recorder path, only into the notes widget path
  • I patched the real recorder path locally during validation and confirmed the intended behavior there

So the user-facing feature is valid, but the working version is the one with the recorder-path fix included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant