Skip to content

Fix invalid reference in gradio_app#28

Merged
JarbasAl merged 3 commits intodevfrom
FIX_GradioApp
Mar 15, 2025
Merged

Fix invalid reference in gradio_app#28
JarbasAl merged 3 commits intodevfrom
FIX_GradioApp

Conversation

@NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Mar 14, 2025

Fix bad reference in gradio_app introduced in v0.0.3
Validated with a Nemo container build
Includes an update to license tests to resolve failing action

Summary by CodeRabbit

  • Chores

    • Refined automated checks to optimize package management during testing by updating the exclusion list for license tests.
  • Bug Fixes

    • Improved the retrieval of available language options in the interactive service for a more reliable selection experience.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update two components. First, the GitHub Actions workflow file now excludes two additional packages—attrs and referencing—from the license tests by modifying the regex pattern for the packages-exclude parameter. Second, within the Gradio application server, the method for retrieving available languages in the bind_gradio_service function has been altered to access the engine attribute directly from the STT engine instead of using the plugin() method.

Changes

File Change Summary
.github/workflows/license_tests.yml Updated the packages-exclude parameter in the license_tests job by extending the regex pattern to exclude attrs and referencing.
ovos_stt_http_server/gradio_app.py Modified bind_gradio_service to retrieve available languages from stt_engine.engine instead of using stt_engine.plugin().

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant G as Gradio Service
    participant STT as STT Engine

    U->>G: Request language options
    G->>STT: Retrieve available_languages from engine attribute
    STT-->>G: Return languages list
    G-->>U: Respond with available languages
Loading

Poem

Hop, skip, and code we go,
Changing regex to give a show.
I spotted a tweak here and there,
Direct engine calls with flair.
Carrots and code, in sync we flow!
🥕🐇 Happy rabbit coding, let's grow!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 3ea49a7 and 029506b.

📒 Files selected for processing (2)
  • .github/workflows/license_tests.yml (1 hunks)
  • ovos_stt_http_server/gradio_app.py (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@NeonDaniel NeonDaniel marked this pull request as ready for review March 14, 2025 22:48
@NeonDaniel NeonDaniel requested a review from JarbasAl March 14, 2025 22:49
@JarbasAl JarbasAl added the fix label Mar 15, 2025
@JarbasAl JarbasAl merged commit 5a0f7bc into dev Mar 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants