rc_exec: add a centralized exec function #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
reviewed
Mar 22, 2025
currently there's a lot of ad-hoc fork exec going around. the goal of this is to centralize most of the typical cases.
since rc_exec uses an `execpipe` to detect exec failures inside the child, this fixes the issue described in 792, but only for the first layer of exec. there's a /bin/sh in the middle and we won't be able to detect whether /bin/sh failed to exec the command without inspecting the (unreliable) exit code. Ref: OpenRC#792
this also fixes a bug in run_program() where signals remained masked in the fork failure case: OpenRC#809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #801