Fix GBK codec error when reading pyproject.toml #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added encoding="utf-8" to file read/write operations in bump_version.py to handle pyproject.toml with UTF-8 encoding, resolving 'gbk' codec can't decode byte 0xbf error at position 1779.
|
@linpan what's the error you're seeing? also looks like you may need to run |
|
@bradhilton in pyproject.toml ,have comment "#中国" “中国” is gbk coding。 |
|
I don't see "#中国" “中国” in |
|
yours pyproject.toml is not gbk, add encoding for edge case. |
|
@linpan can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added encoding="utf-8" to file read/write operations in bump_version.py to handle pyproject.toml with UTF-8 encoding, resolving 'gbk' codec can't decode byte 0xbf error at position 1779.