Skip to content

Data packs with tempos non-divisible by 0.25 aren't exported properly #275

@Bentroen

Description

@Bentroen

In 3.9.1, exporting a song with a tempo that's not a multiple of 0.25 causes the speed score to be set to a decimal value, which makes the load function invalid and prevents the data pack from loading at all.

https://github.com/HielkeMinecraft/OpenNoteBlockStudio/blob/ec65d3836e428f1da118782f367ba3b09f629cf4/scripts/datapack_export/datapack_export.gml#L26

A quick fix is to round the playspeed value to the nearest integer. However, a more "proper" fix would be to increase the tick step score from 80 to 2000 across the whole datapack, so any t/s value in steps of 0.01 is supported.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C: BugSomething isn't workingS: Resolved in next releaseThis bugfix or suggestion has been applied to the code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions