Update Dynamic.Mission.DISTANCE to Dynamic.Mission.GROUND_DISTANCE for clarity#915
Draft
cmbenne3 wants to merge 3 commits intoOpenMDAO:mainfrom
Draft
Update Dynamic.Mission.DISTANCE to Dynamic.Mission.GROUND_DISTANCE for clarity#915cmbenne3 wants to merge 3 commits intoOpenMDAO:mainfrom
cmbenne3 wants to merge 3 commits intoOpenMDAO:mainfrom
Conversation
Contributor
|
I think the only way we keep Range vs. Distance clear for the user is by showing them a diagram. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue 413 and changes the name of the Dynamic.Mission.DISTANCE variable to be more explicit Dynamic.Mission.GROUND_DISTANCE. So there is no confusion about which distance is actually being calculated.
Related Issues
Backwards incompatibilities
Variable change - any custom scripts people have written that interrogate the value of the old variable Dynamic.Mission.DISTANCE will fail as this variable no longer exists.
New Dependencies
None