Update controller selection #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitza-oci
requested changes
Jul 2, 2025
| @@ -328,6 +370,19 @@ void CLIClient::run() | |||
| thr.join(); | |||
| } | |||
|
|
|||
| void CLIClient::set_active_controller(const tms::Identity& device_id, | |||
| const OPENDDS_OPTIONAL_NS::optional<tms::Identity>& master_id) | |||
There was a problem hiding this comment.
One option here would be to require that we build with std::optional, so the macro wouldn't be needed.
There was a problem hiding this comment.
We already require C++17, so we should have it.
| const OPENDDS_OPTIONAL_NS::optional<tms::Identity>& master_id) | ||
| { | ||
| std::lock_guard<std::mutex> guard(active_controllers_m_); | ||
| if (master_id.has_value()) { |
There was a problem hiding this comment.
Comment on lines
+10
to
+14
| : TimerHandler(reactor) | ||
| , device_id_(device_id) | ||
| { | ||
| if (!reactor) { | ||
| reactor_ = new ACE_Reactor; |
There was a problem hiding this comment.
If the TimerHandler constructor (in the future) does anything with its parameter besides just assigning to reactor_ then this could lead to an inconsistency.
One option is to make the TimerHandler (or some other class) take charge of managing the reactor and timer queue, along with the own_reactor_ bit, so it's done in one place.
Co-authored-by: Adam Mitz <[email protected]>
Co-authored-by: Adam Mitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Power device relies on the Heartbeat messages from microgrid controllers to determine its active controller. Heartbeat's period is 1 second. If a Heartbeat is not received from a selected (or active) controller within 3 seconds since the last Heartbeat, the selected controller is considered disappearing and the power device starts a process to select a new selected controller. Current implementation schedule (or reschedule if the timer already exists) a timer with expiration of 3 seconds to detect missed Heartbeats. The default timer queue used by
ACE_Reactor,ACE_Timer_Heap, is having an issue with this setup: missed Heartbeat timers fire even though the Heartbeats are still received from the active controller. This happens around time when the timer Id returned byACE_Timer_Heaphas reached its limit and wrapped around.Solution:
ACE_Timer_Hashfor the ACE reactor --ACE_Timer_Hashdoesn't seem to have the same issue.tms::ActiveMicrogridControllerStatetopic to power devices that gives the CLI updates on their selected controller