Fix SWT Resources disposal runtime warnings in installer #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method createBodyContent calls clearDisposable which empties the disposables collections without actually disposing them leading to dangling references. Make the method actually dispose all disposables before clearing ensures that all resources are actually freed.
|
This fixes the many runtime warnings swt prints about non disposed resources. |
|
bbvcvcvvvvcxxxc:exxx;xcvxevvdvccrddx
…On Fri, Jul 4, 2025, 8:00 AM Philip Wenig ***@***.***> wrote:
Merged #668 <#668> into
develop.
—
Reply to this email directly, view it on GitHub
<#668 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMKRF3JRXQHNMEWBPCKH33GYJ7FAVCNFSM6AAAAACAXZZ5FCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJYGQ3DKMBUGMYDCNA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@akurtakov I fully understand what you mean ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method createBodyContent calls clearDisposable which empties the disposables collections without actually disposing them leading to dangling references.
Make the method actually dispose all disposables before clearing ensures that all resources are actually freed.