Skip to content

Conversation

@zapodot
Copy link
Contributor

@zapodot zapodot commented Feb 12, 2021

To fix #8688

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    Suggested reviewers: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@4brunu
Copy link
Contributor

4brunu commented Feb 12, 2021

I'm not a user of Jackson, so it's hard for me to review this PR.
I have one question, does Jackson require kotlin reflect dependency?

@zapodot
Copy link
Contributor Author

zapodot commented Feb 12, 2021

I'm not a user of Jackson, so it's hard for me to review this PR.
I have one question, does Jackson require kotlin reflect dependency?

Yes, according to the pom of jackson-module-kotlin it does depend on kotlin-reflect: https://github.com/FasterXML/jackson-module-kotlin/blob/master/pom.xml

@wing328 wing328 changed the title [Kotlin] Upgrade jackson version used in the Kotlin client #8688 [Kotlin] Upgrade jackson version used in the Kotlin client Mar 16, 2021
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I've not tested it locally

@wing328 wing328 merged commit 4bfe137 into OpenAPITools:master Mar 17, 2021
@wing328
Copy link
Member

wing328 commented Mar 22, 2021

@zapodot thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

@zapodot zapodot deleted the update-jackson-kotlin-client branch May 27, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kotlin] Jackson is outdated

3 participants