Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

  • prevent further name conflicts by correctly naming the enum, until now there could potentially occur conflicts e.g. 2x MapTestInnerEnum by renaming the items child property
  • correctly set enumName to match datatypeWithEnum

Follow-up for #8220

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

* prevent further name conflicts by correctly naming the enum, until now there could potentially occur conflicts e.g. 2x `MapTestInnerEnum` by renaming the `items` child property
* correctly set `enumName` to match `datatypeWithEnum`
@kuhnroyal
Copy link
Contributor Author

@wing328 Can you merge this please when you get a chance

@agilob
Copy link
Contributor

agilob commented Feb 15, 2021

Will you be ok with these changes being very temporary? I'm planning to use 3rd party library for enum unmarshalling and would like to introduce it soon for dart generator.

@kuhnroyal
Copy link
Contributor Author

This is not really related. Even if you extract the enum serialization, you need the names of enums to be unique, which this change fixes. As the description says, you can still have name collisions without this fix. That would not change with a different form of serialization.

@wing328 wing328 added this to the 5.1.0 milestone Feb 16, 2021
@wing328 wing328 merged commit 608242b into OpenAPITools:master Feb 16, 2021
@kuhnroyal kuhnroyal deleted the dart/improve-inner-enum-naming branch February 16, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants