Skip to content

Conversation

@borsch
Copy link
Member

@borsch borsch commented Jan 27, 2021

Issue #8541
Give ability to extend ApiClient for java-native library

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch
Copy link
Member Author

borsch commented Feb 2, 2021

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@borsch borsch force-pushed the extend-native-apiclient branch from 4363668 to 8069bda Compare February 3, 2021 10:09
Copy link
Contributor

@MosheElisha MosheElisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks! I left one soft comment.

@borsch borsch force-pushed the extend-native-apiclient branch from 8069bda to 183ff49 Compare February 3, 2021 13:17
Copy link
Contributor

@MosheElisha MosheElisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borsch borsch closed this Feb 5, 2021
@borsch borsch reopened this Feb 5, 2021
@borsch
Copy link
Member Author

borsch commented Feb 9, 2021

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@MosheElisha
Copy link
Contributor

@bgong-mdsol @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch @spacether @jimschubert @wing328 mentioning the technical committee as requested and the last modifier of the template file. Please review. Thanks in advance.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 135c8f4 into OpenAPITools:master Feb 16, 2021
@wing328 wing328 added this to the 5.1.0 milestone Feb 16, 2021
@borsch borsch deleted the extend-native-apiclient branch July 22, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants