[jaxrs-cxf][jaxrs-spec] Add missing @NotNull annotation for required body parameters when using BeanValidation #6494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruedigerk
force-pushed
the
fix_issue4280
branch
2 times, most recently
from
7e87739 to
b58d1a7
Compare
wing328
reviewed
Jun 16, 2020
modules/openapi-generator/src/main/resources/JavaJaxRS/spec/bodyParams.mustache
Outdated
Show resolved
Hide resolved
ruedigerk
force-pushed
the
fix_issue4280
branch
2 times, most recently
from
be12925 to
e4f0776
Compare
Contributor
Author
|
I have resolved all issues found in the code review and the PR is waiting since 8 months to be merged. Is there a problem that still needs to be addressed? |
…ters when using BeanValidation.
…ers when using BeanValidation (OpenAPITools#4280).
… required and not nullable.
…e required and not nullable.
…tion for required body parameters when using BeanValidation.
…ation for required body parameters when using BeanValidation.
ruedigerk
force-pushed
the
fix_issue4280
branch
from
e4f0776 to
bbac585
Compare
Contributor
Author
|
@wing328 please merge this PR. I have completed all tasks and I am waiting since months for this fix to be merged. I just rebased it on top of the latest master branch an reran all checks. |
Member
|
@ruedigerk sorry that I missed the update :( Too many users tagged me Thanks for taking my feedback and update the PR accordingly. It looks good to me. |
wing328
approved these changes
Mar 15, 2021
wing328
changed the title
Member
|
@ruedigerk thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing @NotNull annotations for required body parameters when using BeanValidation and fixes #4280.
I fixed all jaxrs generators which use identical bodyParams.mustache files (my company is affected by this bug in the jaxrs-spec generator):
Please review by Java technical committee:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.