Skip to content

[BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format #21698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2025

Conversation

alec-petersen
Copy link
Contributor

@alec-petersen alec-petersen commented Aug 5, 2025

Fixes #21697. Uses the existing ValueConverter object that is generated for each enum.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@alec-petersen alec-petersen changed the title [BUG][CHSARP][GENERICHOST] Write enum values in proper JSON format [BUG][CHSARP][GENERICHOST] Write enum values in expected JSON format Aug 5, 2025
@alec-petersen alec-petersen force-pushed the write-enum-json-value branch from d3ab6db to 837c58b Compare August 5, 2025 16:31
@alec-petersen alec-petersen force-pushed the write-enum-json-value branch from 20ff08b to a1b41d1 Compare August 5, 2025 17:29
@alec-petersen alec-petersen force-pushed the write-enum-json-value branch from a1b41d1 to 755f7d4 Compare August 5, 2025 17:35
@alec-petersen
Copy link
Contributor Author

@alec-petersen alec-petersen changed the title [BUG][CHSARP][GENERICHOST] Write enum values in expected JSON format [BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format Aug 5, 2025
@devhl-labs
Copy link
Contributor

Looks like an obvious improvement. There is another issue open that will require more changes here, so consider adding to the manual test at samples\client\petstore\csharp\generichost\net8\ManualPetstoreTests to ensure it works and continues to work. Thanks for the PR, love the help!

@alec-petersen alec-petersen force-pushed the write-enum-json-value branch from 34ddc56 to e073c83 Compare August 6, 2025 01:56
@wing328
Copy link
Member

wing328 commented Aug 8, 2025

@alec-petersen thanks for the PR

@devhl-labs is this PR ready? if yes, i'll include it in the upcoming release due this weekend

@devhl-labs
Copy link
Contributor

Yup send it

@wing328 wing328 merged commit 3e577d5 into OpenAPITools:master Aug 9, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CSHARP][GENERICHOST] Enums not written to JSON in expected format
3 participants