-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format #21698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][CSHARP][GENERICHOST] Write enum values in expected JSON format #21698
Conversation
d3ab6db
to
837c58b
Compare
20ff08b
to
a1b41d1
Compare
a1b41d1
to
755f7d4
Compare
Looks like an obvious improvement. There is another issue open that will require more changes here, so consider adding to the manual test at samples\client\petstore\csharp\generichost\net8\ManualPetstoreTests to ensure it works and continues to work. Thanks for the PR, love the help! |
34ddc56
to
e073c83
Compare
e073c83
to
bd30424
Compare
@alec-petersen thanks for the PR @devhl-labs is this PR ready? if yes, i'll include it in the upcoming release due this weekend |
Yup send it |
Fixes #21697. Uses the existing ValueConverter object that is generated for each enum.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)"fixes #123"
present in the PR description)