Skip to content

Feat: #21665 [dart][dart-dio] CopyWith for json_serializable #21667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025

Conversation

LahaLuhem
Copy link
Contributor

@LahaLuhem LahaLuhem commented Jul 30, 2025

  1. Add @CopyWith annotation to class template.
  2. Add the required packages in the pubspec template

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

@LahaLuhem LahaLuhem changed the title CopyWith for json_serializable Feat: #21665 [dart][dart-dio] CopyWith for json_serializable Jul 30, 2025
@LahaLuhem LahaLuhem marked this pull request as ready for review July 30, 2025 18:55
@wing328 wing328 added this to the 7.15.0 milestone Jul 31, 2025
@wing328
Copy link
Member

wing328 commented Jul 31, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/16630423609/job/47085879739?pr=21667

please follow step 3 to update the samples

@LahaLuhem
Copy link
Contributor Author

@wing328 Regenerated them 👍🏽

@wing328
Copy link
Member

wing328 commented Aug 1, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@LahaLuhem
Copy link
Contributor Author

LahaLuhem commented Aug 1, 2025

@wing328 Nice catch, I forgot to do rituals after cloning the repo. My commit verfication is broken since forever, do you prefer that I fix it first?
Otherwise fixed it for now. Lmk if you want a specific style for the commit messages or so.

@LahaLuhem
Copy link
Contributor Author

I think I forgot to add in the actual import for it. I'll add it now

@wing328 wing328 merged commit 517bbeb into OpenAPITools:master Aug 7, 2025
16 checks passed
@wing328
Copy link
Member

wing328 commented Aug 7, 2025

since there's no further question/feedback, i've just merged it.

thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants