Skip to content

fix(go): properly generate inline enums #21623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sruehl
Copy link
Contributor

@sruehl sruehl commented Jul 24, 2025

Fixes #9567

The PR added a unit test to demonstrate missing enums as defined in #9567. To validate one can uncomment line 117 in GoClientCodegen.java and then the tests will fail.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

sruehl added 2 commits July 24, 2025 11:23
./mvnw clean package || exit
./bin/generate-samples.sh ./bin/configs/*.yaml || exit
./bin/utils/export_docs_generators.sh || exit
@sruehl sruehl marked this pull request as draft July 24, 2025 09:37
@sruehl
Copy link
Contributor Author

sruehl commented Jul 24, 2025

set to draft for now as it seems that at the moment Enum names collide. This is not unique to inline enums so I wonder how that is solved in general. Any ideas how to fix that @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5?

@sruehl
Copy link
Contributor Author

sruehl commented Jul 24, 2025

also on the note of a "breaking" change. It is breaking and kind of not: The enums have the base type as before so from a user perspective a missing cast is required if the base types are being used. The non-breaking part is that it is still the same more or less. For that reason I was unsure if it is now breaking or non breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][GO] Enums not generated
1 participant