[REQ] C# Make this easy to use again

[awyork]

A few years back, you generated the client. Imported it into your C# project. Use one line line var client = OpenAPi.client(); and you were good to go.

This thing is way too complicated now and defeats the entire purpose of consuming an API. It should be point and go. Rate Limiting? Why? I'm the client. I can rate limit myself.

Time to find a new generator and update my team's documentation.

The current generator doesn't even generate valid code....

GeoJSONMultiLineString(TypeEnum type, List<List<List>>

'Using the generic type 'List' requires 1 type arguments'

A list of a list of a list? But the final list is missing it's type.

[devhl-labs]

Provide yaml so I can reproduce the list issue. That needs to be fixed.

If you don't like the new generated code, the old code is available. Just provide the library option to use restsharp instead. The reason for the change was to modernize and use Generic Host, HttpClient, and System.Text.Json. If you don't want that, then stick to restsharp. Below is an example of how to consume the generated library. You don't even have to worry about the rate limiter because there is on provided by default, though you can override it if you want.

using System;
using System.Threading.Tasks;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Configuration;
using FooBar.Rest.Client;
using System.Collections.Generic;
using System.Linq;
using FooBar.Rest.Extensions;

namespace FooBar.Test;

class Program
{
    public static async Task Main(string[] args)
    {
        await CreateHostBuilder(args).Build().RunAsync();
    }

    private static IHostBuilder CreateHostBuilder(string[] args)
    {
        return Host.CreateDefaultBuilder(args)
            .ConfigureFooBar((context, services, options) =>
            {
                // don't put secrets into your appsettings.json, use environment variables or other appropriate solution for secrets
                List<string> tokenValues = context.Configuration.GetRequiredSection("<your section of appsettings.json>").Get<List<string>>();

                ApiKeyToken[] tokens = tokenValues.Select(t => new ApiKeyToken(t, ClientUtils.ApiKeyHeader.Authorization, timeout: TimeSpan.FromSeconds(1))).ToArray();

                options.AddTokens(tokens);

                options.AddFooBarHttpClients(
                    builder: builder =>
                    {
                        builder
                            .AddRetryPolicy(3)
                            .AddTimeoutPolicy(TimeSpan.FromSeconds(5))
                            .AddCircuitBreakerPolicy(10,TimeSpan.FromSeconds(30));
                    }
                );
            })
            .ConfigureServices((context, services) =>
            {
                // add your services here
                // their constructor should take in one of the api clients as a parameter
            });
    }
}

[wing328]

A few years back, you generated the client. Imported it into your C# project. Use one line line var client = OpenAPi.client(); and you were good to go.

fyi. the latest C# client generator uses generichost (library option) by default

if you want to generate C# client using other HTTP libraries, you can try the restsharp library (e.g. --library restsharp in CLI), which is the previous default

other choices: httpclient, unityWebRequest

ref: https://openapi-generator.tech/docs/generators/csharp/

[awyork]

Thanks guys.

The input file is here: https://api.weather.gov/openapi.json

There's a chance it might not be 100% correct considering the source. Although Postman seems to have consumed it properly.

[awyork]

FWIW....The httpclient option also generates the same issue...

/// <summary>
/// Gets or Sets Coordinates
/// </summary>
[DataMember(Name = "coordinates", IsRequired = true, EmitDefaultValue = true)]
public List<List<List<List>>> Coordinates { get; set; }

[wing328]

For the following schema definition with @id and id

      "Office": {
        "type": "object",
        "properties": {
          "@context": {
            "$ref": "#/components/schemas/JsonLdContext"
          },
          "@type": {
            "enum": [
              "GovernmentOrganization"
            ],
            "type": "string"
          },
          "@id": {
            "type": "string",
            "format": "uri"
          },
          "id": {
            "type": "string"
          },
          "name": {
            "type": "string"
          },

likely one needs to leverage the property name mapping option to avoid naming collision:

https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

[devhl-labs]

I have a branch where I fix the "id" "@id" issue, among some other things. Will send the prs when I can.