Skip to content

Update 1_How_Can_You_Contribute.md #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

Update 1_How_Can_You_Contribute.md #2259

merged 1 commit into from
Sep 29, 2022

Conversation

p2635
Copy link
Collaborator

@p2635 p2635 commented Sep 29, 2022 •
edited by cpholguera
Loading

See #2258

@p2635
Copy link
Collaborator Author

p2635 commented Sep 29, 2022 •
edited
Loading

I might have more suggestions later on so this PR may not close #2258, let me know if the discussion needs to carry on in that thread or whether we should continue the conversation here.

cpholguera
cpholguera approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are very nice suggestions, thank you very much Phil!

@cpholguera
Copy link
Collaborator

Let's remove the "closes" keyword for now so we can merge this one without closing the issue.

@cpholguera cpholguera merged commit b321558 into OWASP:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p2635 @cpholguera