Skip to content

Conversation

TheDauntless
Copy link
Collaborator

This PR changes the following:

  • Modify markdown images to HTML images as per Remove unnecessary backslash #1979
  • Slightly modify the build process so that it works on files in the build folder rather than the original files
  • Make the sed replace pattern for images tolerant for whitespace

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @TheDauntless. Please take a look at the comment. I'm not sure if the commented changes were really intended.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I could still catch :D

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @TheDauntless!

@cpholguera cpholguera merged commit 370c6df into master Jun 27, 2022
@cpholguera cpholguera deleted the fix-markdown-images branch June 27, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants