Skip to content

hot-fix: hamburger dropdown, download buttons, download icons, all news#606

Merged
cwhite911 merged 6 commits intoOSGeo:masterfrom
cwhite911:hot-fix-hamburger
Mar 6, 2026
Merged

hot-fix: hamburger dropdown, download buttons, download icons, all news#606
cwhite911 merged 6 commits intoOSGeo:masterfrom
cwhite911:hot-fix-hamburger

Conversation

@cwhite911
Copy link
Copy Markdown
Contributor

@cwhite911 cwhite911 commented Feb 28, 2026

Fixes

The root issue was caused when we introduced Bootstrap 5 without removing past bootstrap versions and accounting for breaking changes in the bootstrap API.

Main Issue

In this PR I removed Bootstrap 5 and fixed everything to work with Bootstrap 4.1.3 (the current version in our static plugins directory)

Testing

I've also included docker-compose.yml so you can test the changes locally how they will be rendered on the server.

To use install docker and then run.

docker compose -f docker-compose.yml up

The site will be available at http://localhost:1313/.

Moving Forward

This should resolve most of the major issues with the website at the moment and will give us more time to address PR #599 and issue #600 .

I have 3 main goals I'm suggesting we accomplish.

  1. Modernize the websites dependency management to improve consistency between development environments and production. (devcontainer support #552 , Hugo dart scss #599)
  2. Update our dependencies to the latest versions
  3. Switch from css to dart-scss using hugo-extended (Hugo dart scss #599)

The biggest challenges are migrating to Bootstrap 5 (#600) and then we should migrate from Hugo v0.113.0 to v0.157.0. Both of these migrations need planning (Bootstrap issue #600) as they will break parts of the site, but in my opinion it is worth the effort to use the latest features.

@cwhite911
Copy link
Copy Markdown
Contributor Author

This PR also addresses PR #580

@cwhite911 cwhite911 added the bug Something isn't working label Feb 28, 2026
@cwhite911 cwhite911 requested a review from veroandreo February 28, 2026 17:22
@cwhite911 cwhite911 changed the title hot-fix: hamburger dropdown, download buttons, download icons hot-fix: hamburger dropdown, download buttons, download icons, all news Feb 28, 2026
Copy link
Copy Markdown
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hamburger menu works for me as well as the docker setup I tested. (I did not test with my local non-docker setup, but that does not matter much for this.)

In #603, I actually tried to use the green logo without text from static/images/logos/grass-logo-simple for conda. I think actually made it work only for the page itself. I think that's much better than logos with text and old logos.

grass-logo-green-simple@1x

@cwhite911
Copy link
Copy Markdown
Contributor Author

In #603, I actually tried to use the green logo without text from static/images/logos/grass-logo-simple for conda. I think actually made it work only for the page itself. I think that's much better than logos with text and old logos.

I agree when I was initially doing this I was just fixing the links and wasn't trying to update the design, but it's an easy switch and it will all change anyways once PR #546 is merged.

petrasovaa
petrasovaa previously approved these changes Mar 5, 2026
Copy link
Copy Markdown
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hate to postpone this, but only 2 or 3 small fixes to the image would avoid this (Chromium):

Image
  1. source: use the same img as elsewhere
  2. addons: use img instead of object
  3. sample dataset: use img width

@cwhite911
Copy link
Copy Markdown
Contributor Author

cwhite911 commented Mar 6, 2026

I would hate to postpone this, but only 2 or 3 small fixes to the image would avoid this (Chromium):

@wenzeslaus Nice catch. I didn't notice the mixing of object and image tags in the list view when I first looked at it.

Copy link
Copy Markdown
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not build the latest version, but assuming there's no typo...

@cwhite911 cwhite911 merged commit 5eb47ad into OSGeo:master Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

3 participants