hot-fix: hamburger dropdown, download buttons, download icons, all news#606
hot-fix: hamburger dropdown, download buttons, download icons, all news#606cwhite911 merged 6 commits intoOSGeo:masterfrom
Conversation
|
This PR also addresses PR #580 |
wenzeslaus
left a comment
There was a problem hiding this comment.
The hamburger menu works for me as well as the docker setup I tested. (I did not test with my local non-docker setup, but that does not matter much for this.)
In #603, I actually tried to use the green logo without text from static/images/logos/grass-logo-simple for conda. I think actually made it work only for the page itself. I think that's much better than logos with text and old logos.
I agree when I was initially doing this I was just fixing the links and wasn't trying to update the design, but it's an easy switch and it will all change anyways once PR #546 is merged. |
@wenzeslaus Nice catch. I didn't notice the mixing of object and image tags in the list view when I first looked at it. |
wenzeslaus
left a comment
There was a problem hiding this comment.
I did not build the latest version, but assuming there's no typo...

Fixes
The root issue was caused when we introduced Bootstrap 5 without removing past bootstrap versions and accounting for breaking changes in the bootstrap API.
Main Issue
In this PR I removed Bootstrap 5 and fixed everything to work with Bootstrap 4.1.3 (the current version in our static plugins directory)
Testing
I've also included
docker-compose.ymlso you can test the changes locally how they will be rendered on the server.To use install docker and then run.
The site will be available at http://localhost:1313/.
Moving Forward
This should resolve most of the major issues with the website at the moment and will give us more time to address PR #599 and issue #600 .
I have 3 main goals I'm suggesting we accomplish.
The biggest challenges are migrating to Bootstrap 5 (#600) and then we should migrate from Hugo v0.113.0 to v0.157.0. Both of these migrations need planning (Bootstrap issue #600) as they will break parts of the site, but in my opinion it is worth the effort to use the latest features.