Skip to content

Make RelativePath.Parse throw SRE if NamespaceIndexes cannot be found. #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romanett
Copy link
Contributor

@romanett romanett commented May 3, 2025

Make RelativePath.Parse throw SRE if NamespaceIndexes cannot be found or cannot be translated.
Add Tests to verify functionality.

Proposed changes

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett added this to the 1.5.376 Maintenance Update milestone May 3, 2025
@romanett romanett requested a review from mrsuciu May 3, 2025 09:29
@romanett romanett self-assigned this May 3, 2025
Copy link

codecov bot commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (d5fd96b) to head (a10b9ef).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3071      +/-   ##
==========================================
+ Coverage   57.02%   57.18%   +0.15%     
==========================================
  Files         357      357              
  Lines       68951    68961      +10     
  Branches    14156    14156              
==========================================
+ Hits        39317    39432     +115     
+ Misses      25395    25298      -97     
+ Partials     4239     4231       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit 2a7de7d into OPCFoundation:master May 23, 2025
77 checks passed
@romanett romanett deleted the fixRelativePathTranslateNamespaceIndexes branch May 23, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelativePath.Parse should fail for invalid namespace index in browse path
3 participants