Skip to content

feat: PP impact 2025#4565

Merged
mariojsnunes merged 2 commits intomasterfrom
feat/impact-2025
Jan 14, 2026
Merged

feat: PP impact 2025#4565
mariojsnunes merged 2 commits intomasterfrom
feat/impact-2025

Conversation

@mariojsnunes
Copy link
Contributor

PR Checklist

  • - Unit and/or e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Feature

What is the new behavior?

Adds impact entry for 2025.
Made some UX improvements to the form.

Does this PR introduce a DB Schema Change or Migration?

  • No

@mariojsnunes mariojsnunes requested a review from a team as a code owner January 9, 2026 18:56
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Core Team - BAU list Jan 9, 2026
@mariojsnunes mariojsnunes added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 9, 2026
@cypress
Copy link

cypress bot commented Jan 9, 2026

onearmy-community-platform    Run #8393

Run Properties:  status check passed Passed #8393  •  git commit 9c5e31f0eb: fix unit tests
Project onearmy-community-platform
Branch Review feat/impact-2025
Run status status check passed Passed #8393
Run duration 07m 06s
Commit git commit 9c5e31f0eb: fix unit tests
Committer Mário Nunes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 92
View all changes introduced in this branch ↗︎

@benfurber
Copy link
Member

Code looks good. If removing the 'is visible' complexity is part of the brief I think there's more code to be removed? Everything for display and form should go.

@benfurber benfurber moved this from 🆕 Backlog to In progress in Core Team - BAU list Jan 10, 2026
@mariojsnunes
Copy link
Contributor Author

Code looks good. If removing the 'is visible' complexity is part of the brief I think there's more code to be removed? Everything for display and form should go.

hmm not sure what you mean. isVisible wasn't used anywhere, others are still used.

@mariojsnunes mariojsnunes merged commit ea02f50 into master Jan 14, 2026
12 checks passed
@mariojsnunes mariojsnunes deleted the feat/impact-2025 branch January 14, 2026 14:57
@github-project-automation github-project-automation bot moved this from In progress to ✅ Done in Core Team - BAU list Jan 14, 2026
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.102.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants