Merged
Conversation
github-project-automation
bot
added this to
Community Platform and Core Team - BAU list
jproberson
added
the
Review allow-preview ✅
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
fix/4508-breadcrumb-overflow
|
| Run status |
|
| Run duration | 07m 03s |
| Commit |
|
| Committer | Jacob Roberson |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
91
|
| View all changes introduced in this branch ↗︎ | |
Member
|
Looks awesome! That's exactly the behaviour that we want! One last thing would be to hide the scrollbar, but keep the scrolling functionality. This worked for me in devtools on chromium: Here I quickly checked what other browsers might need, but idk: css-8k4646 {
scrollbar-width: none; /* Firefox */
-ms-overflow-style: none; /* IE and Edge */
}
css-8k4646::-webkit-scrollbar {
display: none; /* Chrome, Safari, Opera */
} |
Contributor
Note that no one uses IE or the old Edge anymore, so that line isn't needed |
jproberson
added
Review allow-preview ✅
Member
|
Boom, really nice! |
github-project-automation
bot
moved this from 🆕 Backlog
to ✅ Done
in Core Team - BAU list
Collaborator
|
🎉 This PR is included in version 2.100.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the new behavior?
trying to handle breadcrumbs for mobile better
Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #
What happens next?
Thank you for the contribution! We will review it ASAP.
If you need more immediate feedback you can reach out to us on Discord in the Community Platform
developmentchannel.