feat: change labels from howtos to projects#4027
Conversation
d24a6b7 to
745a68b
Compare
745a68b to
f6b8a74
Compare
f6b8a74 to
b1d74b6
Compare
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4027
|
| Run status |
|
| Run duration | 05m 07s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
2
|
|
|
0
|
|
|
0
|
|
|
77
|
| View all changes introduced in this branch ↗︎ | |
b1d74b6 to
883ac89
Compare
883ac89 to
4699a15
Compare
|
thought I left a comment before but dont see it anymore. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4027 +/- ##
=======================================
Coverage 69.68% 69.68%
=======================================
Files 39 39
Lines 1237 1237
Branches 258 258
=======================================
Hits 862 862
Misses 353 353
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Yes. Definitely went with what seemed most natural to me personally. The principle I tried to go with wast a |
|
Ah i see. It was actually written the other way around, making library the most used word.
|
|
@davehakkens See your point. I'll update. Applying your approach but with some suggestions: Create button Create page Profiles/Contribution tab: Thoughts? |
|
Adding 'project' to the wording often makes it to long for the layout making it look strange Would avoid it |
|
@davehakkens Have a look at this now. |
dd5d3d9 to
eb49393
Compare
41328cc to
9d05585
Compare
|
@davehakkens Actually freshly deployed now: https://community-platform-pr-4027.fly.dev/library?sort=Newest |
|
I see the same as the screenshot above. Is that the latest? |
|
@davehakkens If you refresh and everything you don't see this? |
|
One done. The second is an environement variable so I'll change the default option but the actual prod variables will need changing when this is deployed. |
95bcb5a to
d9e2dc3
Compare
d9e2dc3 to
0581dc2
Compare
0581dc2 to
64803da
Compare
64803da to
a481cdf
Compare
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |




PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
User things are named 'How to', 'how-tos', etc.
What is the new behavior?
Top level is called 'Library', children are called 'projects'. This change is for labels and urls only. Developer things are still called howtos until we migrate the DB.
Does this PR introduce a breaking change?
Git Issues
Part of #3989