Release v3 proper #1298
Merged
Release v3 proper #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Konstantin Baierer <[email protected]>
Co-authored-by: Konstantin Baierer <[email protected]>
Co-authored-by: Konstantin Baierer <[email protected]>
- `Processor.__init__`: remove non-processing kwargs - `Processor.__init__`: deprecate processing kwargs (passing file groups etc) - `Processor`: define members for all non-processing calls - `ocrd_cli_wrap_processor`: non-processing calls instead of init kwargs - `run_processor` and `get_processor` and `cli.bashlib` and `cli.ocrd_tool`: always set processing attributes _after_ init - `Processor.process_workspace`: delegate fileGrp checking to `verify` (still empty) - `DummyProcessor.setup`: no more fileGrp assertions here (too early!) (This is meant to ensure that existing processor implementations, i.e. subclasses of `Processor` do not call `setup` in the constructor anymore. That way, v3.0 will stay backwards compatible in more respects and thus adopting it along the way will become easier.)
- `ocrd_tool.schema.yml`:
- deprecate `input_file_grp`
- deprecate `output_file_grp`
- introduce+require `input_file_grp_cardinality`: number of min:max
- introduce+require `output_file_grp_cardinality`: number of min:max
- `ocrd_utils.assert_file_grp_cardinality`: deprecate
- `Processor.verify`: check that
- fileGrp attributes exist,
- input fileGrp(s) exist in METS
- input/output fileGrp(s) match the cardinality constraints,
if specified in ocrd-tool.json: exact number, or minimum+maximum
number (skipping negative or zero)
(Processor implementors must now specify `input_file_grp_cardinality`
and `output_file_grp_cardinality` in order to have a valid `ocrd-tool.json`
again.)
Processor parallel pages: switch from multithreading to multiprocessing
…lers with propagate=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to flip the switch to v3.0.0.
This PR
ocrd --helpoutput fix help output for multi-line config option descriptions bertsky/core#25ocrd-filterprocessor and XPath functions of v3 API: general XPath 2.0 mechanism, generateDS true reverse mapping, ocrd-filter bertsky/core#21