[17.0][FIX] stock_picking_product_barcode_report: Fix parameter name in barcode generation (type → barcode_type) #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @CarlosRoca13, |
pedrobaeza
reviewed
Jul 22, 2025
| def report_barcode( | ||
| self, | ||
| type, # pylint: disable=redefined-builtin | ||
| barcode_type, # pylint: disable=redefined-builtin |
Member
There was a problem hiding this comment.
You can remove the pylint disable.
…code generation (type → barcode_type)
Anxo82
force-pushed
the
17.0-fix-stock_picking_product_barcode_report
branch
from
521fa47 to
c8aff03
Compare
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 300aa21. Thanks a lot for contributing to OCA. ❤️ |
|
@Anxo82 Could you move it to the next versions if necessary? Thanks 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, barcode images were not rendered correctly in reports when using the gs1_128 format. This was caused by a mismatch between the parameter name used in the report template (type) and the one expected by the controller (barcode_type):
This commit updates the QWeb template to use barcode_type consistently and modifies the controller to accept the correct parameter.
@HaraldPanten @Jaimermaccione
[T-8006]