Skip to content

[17.0][MIG] product_multi_barcode #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 46 commits into from
Jul 30, 2025
Merged

[17.0][MIG] product_multi_barcode #686

OCA-git-bot merged 46 commits into from
Jul 30, 2025

Conversation

@edescalona
Copy link

@edescalona edescalona commented May 13, 2025

@BinhexTeam

Standard migration to 17.

@edescalona edescalona marked this pull request as ready for review May 13, 2025 20:09
@edescalona
Copy link
Author

edescalona commented May 13, 2025

Ready for review

@edescalona edescalona mentioned this pull request May 13, 2025
Open
@edescalona edescalona force-pushed the 17.0-mig-product_multi_barcode branch from ba9c6cf to d0089f4 Compare May 14, 2025 03:01
amandanymeh
amandanymeh suggested changes May 16, 2025
View reviewed changes
Copy link

@amandanymeh amandanymeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, squash the last 2 commits toguether please, Thanks!

@edescalona edescalona force-pushed the 17.0-mig-product_multi_barcode branch from ac1836b to e801e3f Compare May 16, 2025 17:32
@edescalona
Copy link
Author

edescalona commented May 16, 2025

Hi @amandanymeh , squash done, thanks.

@christian-ramos-tecnativa
Copy link

christian-ramos-tecnativa commented May 20, 2025

@edescalona I think you may have squashed too much, unless there's a specific reason the "pre-commit" commit isn't showing up here?

kevinkhao and others added 22 commits May 20, 2025 08:26
@kevinkhao @edescalona
[REF] product_multi_ean: Rename product_mult_ean to product_multi_bar…
e88863d 
…code

[FIX] tests
@jjscarafia @edescalona
[IMP] product_multi_barcode: split py files
7afcb36
@jjscarafia @edescalona
[IMP] product_multi_barcode: run pre-commit
f3fdfda
@jjscarafia @edescalona
[FIX] product_multi_barcode: installation hook
b5112f3
@oca-travis @edescalona
[UPD] Update product_multi_barcode.pot
30e59b0
@OCA-git-bot @edescalona
[UPD] README.rst
26efed5
@kevinkhao @edescalona
[IMP] product_multi_barcode: black, isort, prettier
eb04cf4
@kevinkhao @sebastienbeau @edescalona
[MIG] product_multi_barcode: Migration to 14.0
e170ba0 
Co-authored-by: Sébastien Beau <[email protected]>
@kevinkhao @edescalona
[FIX] remove inverse_sudo
177ea31
@oca-travis @edescalona
[UPD] Update product_multi_barcode.pot
c3f3862
@OCA-git-bot @edescalona
[UPD] README.rst
3381da6
@olgamarcocb @edescalona
[FIX] product_multi_barcode: missing else on a condition
fa5c11c
@OCA-git-bot @edescalona
product_multi_barcode 14.0.1.0.1
45e6d7a
@francesco-ooops @edescalona
Translated using Weblate (Italian)
4f5e3fc 
Currently translated at 100.0% (17 of 17 strings)

Translation: stock-logistics-barcode-14.0/stock-logistics-barcode-14.0-product_multi_barcode
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-14-0/stock-logistics-barcode-14-0-product_multi_barcode/it/
@ilyasProgrammer @edescalona
[14.0][UPD] product_multi_barcode: Updated product variant easy edit …
e80dba7 
…form to see barcodes.
@edescalona
[UPD] Update product_multi_barcode.pot
12c99d9
@OCA-git-bot @edescalona
[UPD] README.rst
2233d63
@OCA-git-bot @edescalona
product_multi_barcode 14.0.1.1.0
ff56f53
@oca-transbot @edescalona
Update translation files
958df35 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-14.0/stock-logistics-barcode-14.0-product_multi_barcode
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-14-0/stock-logistics-barcode-14-0-product_multi_barcode/
@ilyasProgrammer @edescalona
[14.0][FIX] OCA#416
aa8d2dc
@OCA-git-bot @edescalona
product_multi_barcode 14.0.1.1.1
3c464fd
@sebastienbeau @edescalona
product_multi_barcode: fix muti-company access right issue
54db3e2
@edescalona
Copy link
Author

edescalona commented May 20, 2025

Hi @Christian-RB ready for review.

@andres-pcg
Copy link

andres-pcg commented Jun 9, 2025

This should be ready to merge.
Apologies for mentioning you, @pedrobaeza — I just noticed this module doesn’t have a maintainer assigned.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jun 10, 2025

/ocabot migration product_multi_barcode

@amandanymeh should change her review.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 10, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 10, 2025
Open
10 tasks
amandanymeh
amandanymeh approved these changes Jun 13, 2025
View reviewed changes
Copy link

@amandanymeh amandanymeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 13, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@andres-pcg
Copy link

andres-pcg commented Jun 30, 2025

@pedrobaeza this looks ready!

pedrobaeza
pedrobaeza requested changes Jul 1, 2025
View reviewed changes
@andres-pcg
Copy link

andres-pcg commented Jul 16, 2025

@edescalona can you please take a look at Pedro's comments?

@edescalona edescalona force-pushed the 17.0-mig-product_multi_barcode branch 2 times, most recently from 974c007 to 625c522 Compare July 29, 2025 02:18
@edescalona
Copy link
Author

edescalona commented Jul 29, 2025

Hi @pedrobaeza @andres-pcg , thanks for your comments. If you could please review the latest changes, thank you.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jul 29, 2025

Thanks for the changes, Edilio. One last change to merge it: on the migration commit, you have preserved the other commit titles as part of the merged commit message, which is nonsense, as they are not applicable to the migration commit. Please remove that part in the commit message.

@edescalona edescalona force-pushed the 17.0-mig-product_multi_barcode branch from 625c522 to db823f2 Compare July 29, 2025 15:02
@edescalona
Copy link
Author

edescalona commented Jul 29, 2025 •
edited
Loading

Hi @pedrobaeza ready.

pedrobaeza
pedrobaeza approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 30, 2025

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-686-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bdf50f8 into OCA:17.0 Jul 30, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 30, 2025

Congratulations, your PR was merged at ab13cc4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+2 more reviewers

@christian-ramos-tecnativa christian-ramos-tecnativa christian-ramos-tecnativa approved these changes

@amandanymeh amandanymeh amandanymeh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.