[17.0][MIG] stock_barcodes

[edescalona]

@BinhexTeam

This module migration was based on PR #668

Depends on:

• [17.0][MIG] stock_move_line_qty_picked: Backport from 18.0 stock-logistics-workflow#2132

[edescalona]

Ready for review

[edescalona]

Hi @pedrobaeza , this PR already had the improvements from the previous one and some other changes that we added in this version 17.

[pedrobaeza]

Can you enumerate those changes for focusing in them? @Christian-RB you have a requested changes comment.

[edescalona]

@pedrobaeza Here's a list of the changes we've made in version 17:

All items are configurable in the barcode actions associated with the view in which the desired functionality is performed:

1. When making inventory adjustments, you should be able to view the current quantity while recording, taking into account the warehouse and owner. (Option: Show stock)

2. Be able to associate the stock owner from the barcode view. (Option: Show owner)

3. Partial delivery of pickings. (Option: Allow partial delivery)

4. In inventory adjustments, the actual quantity, the expected quantity, and the difference should be displayed.

5. Differentiate the quantity fields for stock and package.

[christian-ramos-tecnativa]

Functional review OK

[nurinayati]

Hello @edescalona I found some issues here:

1. When I try to scan the same product, it does not increase the quantity and remains 1

2. I am not sure how to use the barcode action scan. I have filled the barcode on the barcode action however, when I scan it, nothing happens. let me know if I missed some configuration :)

3. By Default, the scanned qty should be 0, same logic as v16

[edescalona]

Hi @nurinayati , regarding the points you mentioned:

1. Go to the Inventory -> Configuration -> Barcode Options menu and select the Accumulate Read Quantity option, as shown in the image.

2. That barcode field is for opening the barcode action from the main Barcodes view according to the code reflected in the field that is shown to me.

3. By default, in version 17, demand and quantity are equal.

Thank you for your comments.

[christian-ramos-tecnativa]

Hello @edescalona,

After some testing, I noticed that in an internal transfer, the destination location is filtered by the current warehouse:

While I understand that internal transfers are generally intended for moves between locations within the same warehouse, the standard behavior actually allows selecting locations from other warehouses:

What do you think about keeping the filter consistent with the standard?

[edescalona]

Hi @Christian-RB , it could be an option within the barcode options, leaving both approaches.

What do you think, @pedr @ws, about what was discussed (#677 (comment))?

[nurinayati]

Thank you for your reply @edescalona :)

1. I have checked the boolean, and the issue is still there.
2. Yes I was trying to scan the barcode on that screen and nothing happens. please let me know if i missed anything to check
3. Ok, that makes sense, but I think it would be better to display the unscanned quantity like Barcode app in Odoo EE 17
4. I found another error when trying to scan a barcode that is not in the list. it should have an error-handling message. How to reproduce: display 2 picking with different tabs of barcode app and scan a product that is not in the list
   https://www.awesomescreenshot.com/video/43597551?key=afffe58a592f8eacf79ceab0769be8fa

[edescalona]

Hi @nurinayati , thanks for your comments. Could you please copy the error message you showed me in point 4? I'd like to follow the steps you mentioned and it doesn't show me that error. Thanks.

[nurinayati]

Hi @edescalona Please see the error below. yes the error is not always showing, but I got the error somehow if I have 2 active barcode screen with different stock pickings :)

UncaughtClientError > TypeError
Uncaught Javascript Error > Cannot read properties of undefined (reading 'writeText')

TypeError: Cannot read properties of undefined (reading 'writeText')
at ClientErrorDialog.onClickClipboard (http://oca-stock-logistics-barcode-17-0-pr677-281c21440047.runboat.odoo-community.org/web/assets/dbbc27e/web.assets_web.min.js:2382:48)
at Object.mainEventHandler (http://oca-stock-logistics-barcode-17-0-pr677-281c21440047.runboat.odoo-community.org/web/assets/dbbc27e/web.assets_web.min.js:1593:77)
at HTMLButtonElement.listener (http://oca-stock-logistics-barcode-17-0-pr677-281c21440047.runboat.odoo-community.org/web/assets/dbbc27e/web.assets_web.min.js:748:15)

[florian-dacosta]

Hello @edescalona,
Thanks for this migration work.

3. By default, in version 17, demand and quantity are equal.

As @nurinayati I concerned about it.
The first goal of the barcode reader is to scan the products than need to be picked. If the barcode reader application already fill the quantity as if it had been picked, it make the application useless in most of the "picking" cases no ?
I don't understand how to use the barcode reader application for picking if the quantity are prefilled !

Odoo SA did remove the qty_done field on stock.move.line from the stock module, but they still have the same behavior on their barcode app (quantity of each line are set to 0 and increased on scan). I guess they did add it or a similar field in the barcode module.
Also I see you did add the qty_done field back on stock.move.line, I think we could/should use it along with the picked boolean (else I am not sure why you had to add it back?).
This way, as in v16, we can start with a 0 quantity, record what has been scanned with qty done, and use the picked boolean when the full quantity of the line is scanned.

From what I just did test on a v18 runbot, the enterprise application does split the stock.move.line in case everything is not scanned.
For example, I need to pick a product 40 times, I have 1 stock.move.line. If I scan the barcode 10 times and then leave the barcode interface, we will have then 2 stock.move.line. One with quantity 10 marked as picked, the other of 30, which remains to do.

A second thing I saw during the quick test I made on runboat : when I edit the quantity of a line manually, I can't set a 0 quantity. When I put 0 and then confirm, nothing happens.

I'd appreciate your feedback on those 2 points!
Thanks again for your huge work on this module.

[etobella]

Before doing anything, review this:

#718

[christian-ramos-tecnativa]

This PR now depends on OCA/stock-logistics-workflow#2132
Thanks, @florian-dacosta, for your guidance! 🙏
The functionality for splitting stock.move.line is still missing.
@sergio-teruel, what do you think about setting up a short meeting to discuss the remaining work for versions 17 and 18?
It seems we might be working on the same issues in parallel, so coordinating could help us split the workload more efficiently.
Thanks!

[pedrobaeza]

Please check the work done on the 18.0 migration in #725 to coordinate.

[mariano-aferrari]

Hi everyone, any progress on this module for Odoo 17?. Could you please provide an update on where you are standing with it?. Thanks!

[pedrobaeza]

You should take into account #733