Skip to content

[IMP] product_multi_barcode: Performance #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 2 commits into from
Jun 22, 2025
Merged

[IMP] product_multi_barcode: Performance #666

OCA-git-bot merged 2 commits into from
Jun 22, 2025

Conversation

@GabbasovDinar
Copy link
Member

@GabbasovDinar GabbasovDinar commented Dec 17, 2024

Improve search speed when searching products by name.

Task: 4183

The similar solution for a similar problem: OCA/stock-logistics-tracking#40

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Dec 18, 2024

Hey @rousseldenis this is the same patch as we did for our module here: OCA/stock-logistics-tracking#40
I think this should be a good performance improvement for this module as well.

ivs-cetmix
ivs-cetmix approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM.

@Bearnard21 Bearnard21 force-pushed the 16.0-t4183-product_multi_barcode-imp-performance branch 6 times, most recently from 375fe54 to 4af208c Compare February 18, 2025 18:03
Bearnard21
Bearnard21 approved these changes Feb 18, 2025
View reviewed changes
Copy link

@Bearnard21 Bearnard21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@Bearnard21 Bearnard21 force-pushed the 16.0-t4183-product_multi_barcode-imp-performance branch 2 times, most recently from 82bfb3b to fd0bc49 Compare February 18, 2025 18:07
@Bearnard21
Copy link

Bearnard21 commented Feb 18, 2025

@jbaudoux please take a look

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Feb 18, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Bearnard21 Bearnard21 force-pushed the 16.0-t4183-product_multi_barcode-imp-performance branch from fd0bc49 to 83a3b24 Compare February 18, 2025 20:16
@github-actions
Copy link

github-actions bot commented Jun 22, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 22, 2025
GabbasovDinar and others added 2 commits June 22, 2025 16:48
@GabbasovDinar @ivs-cetmix
[IMP] product_multi_barcode: Performance
817cd79 
Improve search speed when searching products by name.

Task: 4183
@ivs-cetmix
[IMP] product_multi_barcode: readme improved
8f971a5 
Improve Readme USAGE, DESCRIPTIOM files and add the screenshot to be more user-friendly
@ivs-cetmix ivs-cetmix force-pushed the 16.0-t4183-product_multi_barcode-imp-performance branch from 83a3b24 to 8f971a5 Compare June 22, 2025 14:48
@ivs-cetmix
Copy link
Member

ivs-cetmix commented Jun 22, 2025

Hey @OCA/logistics-maintainers let's make OCA faster together! 😄

rvalyi
rvalyi approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi
Copy link
Member

rvalyi commented Jun 22, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 22, 2025

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-666-by-rvalyi-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19584aa into OCA:16.0 Jun 22, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 22, 2025

Congratulations, your PR was merged at 984bfd7. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 22, 2025
This was referenced Sep 17, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvalyi rvalyi rvalyi approved these changes

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

+1 more reviewer

@Bearnard21 Bearnard21 Bearnard21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

6 participants

@GabbasovDinar @ivs-cetmix @Bearnard21 @OCA-git-bot @rvalyi @pedrobaeza