[17.0][MIG] barcodes_generator_product: Migration to 17.0 #620

isaako34 · 2024-05-30T02:17:02Z

Migrate the module barcodes_generator_product to V17.
This PR supersedes the PR#594

isaako34 · 2024-05-30T05:38:25Z

@luisg123v Could you please review.

luisg123v · 2024-05-31T01:09:50Z

barcodes_generator_product/demo/res_users.xml

+        <field
+            name="groups_id"
+            eval="[
+            (4, ref('product.group_product_variant')),


Use the Command syntax

Same in demo/product.xml

luisg123v · 2024-05-31T01:11:32Z

barcodes_generator_product/tests/test_barcodes_generator_product.py

+class Tests(TransactionCase):
+    """Tests 'Barcodes Generator for Products'"""
+
+    def setUp(self):


setUpClass

isaako34 · 2024-05-31T17:54:47Z

@luisg123v ready for review.

desdelinux · 2024-06-06T16:45:41Z

Hi @luisg123v @pedrobaeza this is ready for review

luisg123v

LGTM 👍

dalonsod · 2024-06-07T11:19:32Z

@isaako34 , could you make the following tasks?

Fix DESCRIPTION.md file, that seems to be bad formatted from the very first version. Some of its content might be formatted as an unordered list, but it's shown in the same line:
Clean commit history as described at https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Thanks for this migration!

desdelinux · 2024-06-07T17:56:02Z

@isaako34 , could you make the following tasks?

Fix DESCRIPTION.md file, that seems to be bad formatted from the very first version. Some of its content might be formatted as an unordered list, but it's shown in the same line:

Clean commit history as described at https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Thanks for this migration!

Hi @dalonsod , I don't understand what you want to do with your second comment. The migration must have all the commit history

luisg123v · 2024-06-07T18:02:46Z

@desdelinux administrative commits (the ones done by bots) should be squashed, it's documented in the process on how bring history.

rousseldenis · 2024-06-11T18:00:41Z

/ocabot migration barcodes_generator_product

OCA-git-bot · 2024-06-11T18:00:59Z

The migration issue (#555) has not been updated to reference the current pull request because a previous pull request (#594) is not closed.
Perhaps you should check that there is no duplicate work.
CC @jvandri

* Rename manifest * Change openerp references to odoo * Bump version * Fix spelling errors and add product avatar to icon * Remove product_barcode_generator

Currently translated at 94.1% (16 of 17 strings) Translation: stock-logistics-barcode-16.0/stock-logistics-barcode-16.0-barcodes_generator_product Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-16-0/stock-logistics-barcode-16-0-barcodes_generator_product/fr/

Currently translated at 100.0% (17 of 17 strings) Translation: stock-logistics-barcode-16.0/stock-logistics-barcode-16.0-barcodes_generator_product Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-16-0/stock-logistics-barcode-16-0-barcodes_generator_product/it/

…le_id, to avoid an OWL error 'TypeError: record is undefined'. Remark : It doesn't makes sense to edit barcode rule via product / template, as it should be managed via barcode nomenclature form view

- Migrate views using the module `views_migration_v17` - Remove the 'priority' field in views. - Remove the 'replace' attribute from views and apply the 'after' attribute instead. - Migrate setUp to setUpClass. - Apply command syntax. - Fix the unordered list in DESCRIPTION.md and README.rst files.

legalsylvain

a minor remark inline. Otherwise, LGTM . Thanks !

legalsylvain · 2024-06-11T19:15:34Z

barcodes_generator_product/views/view_product_product.xml

+
+            <field name="barcode" position="attributes">
+                <attribute name="invisible">True</attribute>
+            </field>
+            <field name="barcode" position="after">
+                <label for="barcode" />
+                <div name="div_barcode" class="o_row">
+                    <field
+                        name="barcode"


With this new design, barcode fields is in the form two times. AFAIK, it can generate trouble. Don't you think ?

Hello @legalsylvain, this behavior is expected since V16:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Thanks ! I didn't know !

legalsylvain

LGTM. Thanks !

luisg123v

LGTM 👍

Hi @moylopp260,

Could you review/merge, please?

CC @desdelinux

rousseldenis · 2024-06-14T07:13:12Z

/ocabot migration barcodes_generator_product

desdelinux · 2024-06-17T15:15:53Z

Hi @rousseldenis @moylop260 @pedrobaeza this is ready :)

could you review/merge, please?

moylop260 · 2024-06-17T16:02:37Z

/ocabot merge nobump

OCA-git-bot · 2024-06-17T16:02:56Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-620-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-17T16:06:47Z

Congratulations, your PR was merged at 68ee8c9. Thanks a lot for contributing to OCA. ❤️

New module barcode_generator_product

5f97a78

isaako34 force-pushed the 17.0-mig-barcodes_generator_product branch from 29753e8 to 52d0633 Compare May 30, 2024 05:30

luisg123v suggested changes May 31, 2024

View reviewed changes

isaako34 force-pushed the 17.0-mig-barcodes_generator_product branch from 52d0633 to b81c11e Compare May 31, 2024 17:43

isaako34 requested a review from luisg123v May 31, 2024 17:58

luisg123v approved these changes Jun 6, 2024

View reviewed changes

isaako34 force-pushed the 17.0-mig-barcodes_generator_product branch 2 times, most recently from e0844ed to ab3d3be Compare June 11, 2024 16:48

rousseldenis added needs review migration labels Jun 11, 2024

OCA-git-bot added this to the 17.0 milestone Jun 11, 2024

rousseldenis mentioned this pull request Jun 11, 2024

[17.0][MIG] barcodes_generator_product: Migration to 17.0 #594

Closed

lasley and others added 10 commits June 11, 2024 18:46

[MIG] barcodes_product_generator: Upgrade to v10

9975bc6

* Rename manifest * Change openerp references to odoo * Bump version * Fix spelling errors and add product avatar to icon * Remove product_barcode_generator

[MIG] barcodes_generator_product: Migration to 11.0

7719c7b

11.0 [MIG] barcode_generator_lot

83dd76b

[MIG] barcodes_generator_product: Migration to 12.0

79ca37d

Added translation using Weblate (Chinese (Simplified))

84e9c9d

Added translation using Weblate (Italian)

6766ac9

[IMP] barcodes_generator_product: black, isort, prettier

0f58e5a

[MIG] barcodes_generator_product: Migration to v13.0

95ec748

[IMP] barcodes_generator_product: black, isort, prettier

c89d1e2

[MIG] barcodes_generator_product: Migration to 14.0

8710eed

pedrobaeza and others added 6 commits June 11, 2024 18:46

[FIX] barcodes_generator_*: Linter fixes

de21d7e

[IMP] barcodes_generator_product: clarify documentation

9a3a420

[FIX] barcodes_generator_product : set widget selection on barcode_ru…

801363c

…le_id, to avoid an OWL error 'TypeError: record is undefined'. Remark : It doesn't makes sense to edit barcode rule via product / template, as it should be managed via barcode nomenclature form view

[IMP] barcodes_generator_product: pre-commit auto fixes

5b48ff7

isaako34 force-pushed the 17.0-mig-barcodes_generator_product branch 2 times, most recently from 0c098d0 to 377f8e6 Compare June 11, 2024 19:03

isaako34 force-pushed the 17.0-mig-barcodes_generator_product branch from 377f8e6 to 1399a74 Compare June 11, 2024 19:09

isaako34 requested a review from luisg123v June 11, 2024 19:10

legalsylvain reviewed Jun 11, 2024

View reviewed changes

legalsylvain approved these changes Jun 12, 2024

View reviewed changes

OCA-git-bot added the approved label Jun 12, 2024

desdelinux approved these changes Jun 12, 2024

View reviewed changes

luisg123v approved these changes Jun 13, 2024

View reviewed changes

rousseldenis approved these changes Jun 14, 2024

View reviewed changes

OCA-git-bot mentioned this pull request Jun 14, 2024

Migration to version 17.0 #555

Open

10 tasks

desdelinux approved these changes Jun 14, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jun 17, 2024

OCA-git-bot merged commit a3fa837 into OCA:17.0 Jun 17, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 17, 2024

luisg123v deleted the 17.0-mig-barcodes_generator_product branch June 17, 2024 16:16

Uh oh!

[17.0][MIG] barcodes_generator_product: Migration to 17.0 #620

[17.0][MIG] barcodes_generator_product: Migration to 17.0 #620

Uh oh!

Conversation

isaako34 commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isaako34 commented May 30, 2024

Uh oh!

luisg123v May 31, 2024

Choose a reason for hiding this comment

Uh oh!

luisg123v May 31, 2024

Choose a reason for hiding this comment

Uh oh!

isaako34 commented May 31, 2024

Uh oh!

desdelinux commented Jun 6, 2024

Uh oh!

luisg123v left a comment

Choose a reason for hiding this comment

Uh oh!

dalonsod commented Jun 7, 2024

Uh oh!

desdelinux commented Jun 7, 2024

Uh oh!

luisg123v commented Jun 7, 2024

Uh oh!

rousseldenis commented Jun 11, 2024

Uh oh!

OCA-git-bot commented Jun 11, 2024

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

legalsylvain Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

isaako34 Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

legalsylvain Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

luisg123v left a comment

Choose a reason for hiding this comment

Uh oh!

rousseldenis commented Jun 14, 2024

Uh oh!

desdelinux commented Jun 17, 2024

Uh oh!

moylop260 commented Jun 17, 2024

Uh oh!

OCA-git-bot commented Jun 17, 2024

Uh oh!

OCA-git-bot commented Jun 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

isaako34 commented May 30, 2024 •

edited

Loading