-
-
Notifications
You must be signed in to change notification settings - Fork 492
[18.0][MIG] auth_oauth_autologin: Migration to 18.0 #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
…of the URI fragment to redirect to
895538c to
c637c01
Compare
|
Hi @sbidoul , I have refactored the module to use a pure backend redirect v18-autologin.mp4 |
|
I have some doubts with the redirect implementation, in particular when the user is already logged in . Could you pick-up the tests from #821 ? The implementation in #821 is a bit different, as is the original implementation in f25f5d4 which calls super first. I don't know which approach is better in 18.0. |
|
Can you also remove the old icon so the bot will generate a new one after merge? |
c637c01 to
8c3d84e
Compare
8c3d84e to
7376795
Compare
|
Hi @sbidoul , I've removed the icon and added the tests |
No description provided.