[14.0][MIG] auth_saml #268

theangryangel · 2021-04-23T08:59:57Z

Forward port of #214.

We've got this running on our production install so I'm reasonably happy it's OK. Again happy to learn/take comments, etc. :)

auth_saml/__manifest__.py

yvaucher · 2021-06-23T07:23:30Z

FTR we created this module to automatise the configuration of this module by environment:

https://github.com/OCA/server-env/pull/74/files

auth_saml/controllers/main.py

yvaucher · 2021-06-23T08:58:13Z

@theangryangel I propesed you a PR to extend the configurations on signatures here:
GlodoUK#6

yvaucher · 2021-06-23T14:23:20Z

@theangryangel beware my change is broken on the signatures I missed some self.sign

yvaucher · 2021-06-23T14:29:35Z

@theangryangel feel free to remove my commit as it is unstable.

OCA-git-bot · 2021-06-23T18:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

houssine78 · 2021-06-24T14:12:57Z

@pedrobaeza this PR seems ready to be merged ! :)

pedrobaeza

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0.

Please squash migration commits as well.

savijoki · 2021-09-01T07:31:22Z

@theangryangel Hey, what's the situation with this PR, any estimation when this will merged?

Does the module make it possible for users to signup automatically if no user with matching attribute exist and Free sign up is enabled?

theangryangel · 2021-09-01T08:09:23Z

@theangryangel Hey, what's the situation with this PR, any estimation when this will merged?

@savijoki no idea, I don't have the ability to merge into this repo. Ignoring the pre-commit issue (which is a 2 minute fix that I'll sort today), this is in the same state that the 13.0 was. You can see how long that took here.

If it helps we are running it in production direct from the branch, it should be relatively safe to do so.

Does the module make it possible for users to signup automatically if no user with matching attribute exist and Free sign up is enabled?

Currently no. In terms of user setup both the 13.0 and 14.0 ports follow how 12.0 was implemented.

It could certainly be added, but in my experience you'd need someone to go and fiddle with the user account to set the correct permissions for a new user anyway. Very few of our customers all run with the same group memberships 🤷

bodedra

Functional review. 👍 works great on 14.0 (Enterprise)

Possible addition on this module: Allow to auto create users in Odoo if not present

houssine78 · 2021-09-17T12:09:23Z

auth_saml/__manifest__.py

+    "website": "https://github.com/OCA/server-auth",
+    "license": "AGPL-3",
+    "depends": ["base_setup"],
+    "external_dependencies": {"python": ["pysaml2"]},


I'm wondering if it is saml2 that is used instead of pysaml2

This is what’s used:

https://github.com/IdentityPython/pysaml2

https://pypi.org/project/pysaml2/

houssine78 · 2021-09-19T09:02:36Z

Hi @pedrobaeza this PR is now ready to be merged. Thanks

Formal requirements met

The following line of code for 11.0: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/controllers/main.py#L69 is assigning the key "auth_link" for "list_providers" method. The following template is expecting this key: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/views/auth_oauth_templates.xml#L5 So, it raise a KeyError compiling "template_auth_oauth_providers_N" This change is fixing adding that expected key in order to avoid this KeyError

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_saml/

[FIX] dependencies

add requirement on lasso

- Default behavior is now to allow password and SAML together. Otherwise, users could keep getting their passwords removed without warning. - General cleanup. - Remove relations to field `password_crypt` because in v12 the `password` field is always encrypted instead. Co-Authored-By: Alexandre Díaz <[email protected]>

…ct uses old data

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-12.0/server-auth-12.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_saml/

theangryangel · 2021-09-20T08:40:10Z

This branch needs to be rebased and fix pre-commit stuff.

Rebased, pre-commit manually run and pushed. Sorry, I thought I had done that weeks ago for some reason.

houssine78 · 2021-09-24T06:57:22Z

Hi @pedrobaeza it has been rebased. I hope this time is the right one.

pedrobaeza · 2021-09-24T07:05:42Z

/ocabot merge nobump

OCA-git-bot · 2021-09-24T07:05:54Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-268-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2021-09-24T07:21:22Z

Congratulations, your PR was merged at 0af0920. Thanks a lot for contributing to OCA. ❤️

houssine78 · 2021-09-24T08:39:06Z

thanks @pedrobaeza !

simahawk · 2022-01-14T09:14:47Z

FTR tests for this module are broken ATM #330

Syncing from upstream OCA/server-auth (13.0)

theangryangel mentioned this pull request Apr 23, 2021

Migration to version 14.0 #220

Closed

17 tasks

yvaucher approved these changes May 12, 2021

View reviewed changes

leemannd reviewed May 17, 2021

View reviewed changes

auth_saml/__manifest__.py Outdated Show resolved Hide resolved

theangryangel force-pushed the feat/14.0-mig-auth_saml branch from 6132212 to bca1241 Compare May 28, 2021 16:10

leemannd mentioned this pull request Jun 17, 2021

[14.0][ADD] auth_saml_enviroment OCA/server-env#74

Merged

leemannd approved these changes Jun 23, 2021

View reviewed changes

OCA-git-bot added the approved label Jun 23, 2021

yvaucher reviewed Jun 23, 2021

View reviewed changes

auth_saml/controllers/main.py Outdated Show resolved Hide resolved

OCA-git-bot added the ready to merge label Jun 23, 2021

pedrobaeza previously requested changes Jun 24, 2021

View reviewed changes

OCA-git-bot removed approved ready to merge labels Jun 24, 2021

theangryangel force-pushed the feat/14.0-mig-auth_saml branch from 1358c57 to 74ba896 Compare June 25, 2021 08:46

theangryangel requested a review from pedrobaeza June 25, 2021 08:48

theangryangel force-pushed the feat/14.0-mig-auth_saml branch from 74ba896 to 7218cd1 Compare June 25, 2021 09:34

theangryangel force-pushed the feat/14.0-mig-auth_saml branch from 7218cd1 to ed2f30f Compare August 14, 2021 14:38

bodedra approved these changes Sep 15, 2021

View reviewed changes

houssine78 reviewed Sep 17, 2021

View reviewed changes

houssine78 approved these changes Sep 19, 2021

View reviewed changes

OCA-git-bot added the approved label Sep 19, 2021

yvaucher and others added 17 commits September 20, 2021 09:31

Typo

f30265e

[UPD] Update auth_saml.pot

85c8e5d

[ADD] icon.png

faa40a4

[FIX] auth_saml: Remove broken symlink

1137bf4

[UPD] Update auth_saml.pot

d42f851

Update translation files

782b682

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_saml/

[FIX] dependencies

dcf9f0b

[FIX] dependencies

[MIG] auth_saml to 12.0

fb3113b

add requirement on lasso

[UPD] README.rst

d91327d

FIX auth_saml committing saml_access_token otherwise login_and_redire…

c7e2248

…ct uses old data

[UPD] Update auth_saml.pot

8d0e9b6

Update translation files

9e421e4

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-12.0/server-auth-12.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_saml/

auth_saml 12.0.1.0.1

149989b

[IMP] auth_saml: black, isort, prettier

0551a3d

[MIG] auth_saml: Migration to 14.0

9f60a1a

theangryangel force-pushed the feat/14.0-mig-auth_saml branch from ed2f30f to 9f60a1a Compare September 20, 2021 08:34

OCA-git-bot added the bot is merging ⏳ label Sep 24, 2021

OCA-git-bot merged commit e0431ce into OCA:14.0 Sep 24, 2021

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 24, 2021

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#268 from OCA/13.0

872a947

Syncing from upstream OCA/server-auth (13.0)

Uh oh!

[14.0][MIG] auth_saml #268

[14.0][MIG] auth_saml #268

Uh oh!

Conversation

theangryangel commented Apr 23, 2021

Uh oh!

Uh oh!

yvaucher commented Jun 23, 2021

Uh oh!

Uh oh!

yvaucher commented Jun 23, 2021

Uh oh!

yvaucher commented Jun 23, 2021

Uh oh!

yvaucher commented Jun 23, 2021

Uh oh!

OCA-git-bot commented Jun 23, 2021

Uh oh!

houssine78 commented Jun 24, 2021

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

savijoki commented Sep 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theangryangel commented Sep 1, 2021

Uh oh!

bodedra left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

houssine78 Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

theangryangel Sep 18, 2021

Choose a reason for hiding this comment

Uh oh!

houssine78 commented Sep 19, 2021

Uh oh!

theangryangel commented Sep 20, 2021

Uh oh!

houssine78 commented Sep 24, 2021

Uh oh!

pedrobaeza commented Sep 24, 2021

Uh oh!

OCA-git-bot commented Sep 24, 2021

Uh oh!

OCA-git-bot commented Sep 24, 2021

Uh oh!

houssine78 commented Sep 24, 2021

Uh oh!

simahawk commented Jan 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

savijoki commented Sep 1, 2021 •

edited

Loading

bodedra left a comment •

edited

Loading