Skip to content

[16.0][FIX] product_packaging_level: add true migration scripts #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Aug 26, 2025
Merged

[16.0][FIX] product_packaging_level: add true migration scripts #1963

OCA-git-bot merged 1 commit into from
Aug 26, 2025

Conversation

@MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Apr 30, 2025 •
edited
Loading

@MiquelRForgeFlow MiquelRForgeFlow mentioned this pull request Apr 30, 2025
Merged
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-product_packaging_level-migration-scripts branch from 4ef182f to 8676fa5 Compare April 30, 2025 09:31
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Apr 30, 2025

ping @pedrobaeza

@pedrobaeza
Copy link
Member

pedrobaeza commented Apr 30, 2025

I don't use this module, so I can't say.

@pedrobaeza pedrobaeza added this to the 16.0 milestone Apr 30, 2025
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-product_packaging_level-migration-scripts branch from 8676fa5 to b5d483b Compare April 30, 2025 10:23
jbaudoux
jbaudoux reviewed Apr 30, 2025
View reviewed changes
sebalix
sebalix reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, I'll test that locally and get back to you

jbaudoux
jbaudoux reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you drop changes to index.html ?

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-product_packaging_level-migration-scripts branch from b5d483b to ab8a8a0 Compare April 30, 2025 12:29
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 16.0-fix-product_packaging_level-migration-scripts branch from ab8a8a0 to c96848f Compare April 30, 2025 12:34
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Apr 30, 2025

can you drop changes to index.html ?

Done.

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented May 15, 2025

@sebalix have you tested?

sebalix
sebalix approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jun 2, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Jun 20, 2025

Could we merge this?

hparfr
hparfr reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest["version"] is now 16.0.1.2.1 https://github.com/OCA/product-attribute/blob/16.0/product_packaging_level/__manifest__.py#L6

Should these migrations scripts be renamed ?

@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Jul 8, 2025 •
edited
Loading

Should these migrations scripts be renamed ?

No, the point is them to be executed immediately in migration, so they are fine being in 16.0.1.0.0.

@rousseldenis
Copy link
Contributor

rousseldenis commented Aug 26, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1963-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5906e0 into OCA:16.0 Aug 26, 2025
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 26, 2025

Congratulations, your PR was merged at 4abb217. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-fix-product_packaging_level-migration-scripts branch August 31, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebalix sebalix sebalix approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

+2 more reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@hparfr hparfr hparfr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

7 participants

@MiquelRForgeFlow @pedrobaeza @OCA-git-bot @rousseldenis @sebalix @jbaudoux @hparfr