[17.0][MIG] maintenance_inspection #524
Conversation
edescalona
force-pushed
the
17.0-mig-maintenance_inspection
branch
from
8b7e556 to
1b072dd
Compare
ypapouin
left a comment
ypapouin
left a comment
There was a problem hiding this comment.
You cannot re-use my PR as is. First, because I believe that action path has been introduced in 18.0, and secondly because Odoo 17.0 is using the legacy Kanban view.
You have to remove these two commits:
- [MIG] maintenance_inspection: Kanban view updated
- [IMP] maintenance_plan: Path added to action
|
ping @ypapouin |
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Please consider my suggestions. Also, I think the last commit should be squashed.
I think it would be better to leave that revert history as is, don't you think? |
Let's see what others think about it |
I have no problem removing it; I just checked different pull requests and there are commits like that, but I'll proceed to remove it. Thanks. |
edescalona
force-pushed
the
17.0-mig-maintenance_inspection
branch
from
7411373 to
43f1104
Compare
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
Currently translated at 100.0% (34 of 34 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_inspection Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_inspection/fr/
edescalona
force-pushed
the
17.0-mig-maintenance_inspection
branch
from
43f1104 to
5375cf9
Compare
5 participants
@BinhexTeam
Based on