Skip to content

Conversation

@kaynnan
Copy link
Contributor

@kaynnan kaynnan commented Jun 21, 2023

cc @marcelsavegnago

The changes in _onchange_product_id were made because the error message indicated that the product.supplierinfo object didn't have a name attribute. Therefore, the code was modified to assign the value to partner_id, and it had the same effect.

@kaynnan kaynnan force-pushed the 16.0-mig-maintenance_product branch 6 times, most recently from 365d1d1 to b8ac35a Compare June 21, 2023 14:24
@kaynnan kaynnan marked this pull request as ready for review June 21, 2023 14:48
@kaynnan kaynnan force-pushed the 16.0-mig-maintenance_product branch from b8ac35a to 3580e18 Compare June 30, 2023 15:16
@etobella
Copy link
Member

etobella commented Jul 5, 2023

Can you join your two commits?

/ocabot migration maintenance_product

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 5, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 5, 2023
24 tasks
@kaynnan kaynnan force-pushed the 16.0-mig-maintenance_product branch from 3580e18 to bcdbe73 Compare July 5, 2023 21:43
@kaynnan
Copy link
Contributor Author

kaynnan commented Jul 5, 2023

Can you join your two commits?

/ocabot migration maintenance_product

Thanks for the suggestion, i made the squash commits

@etobella
Copy link
Member

etobella commented Jul 5, 2023

There is still two commits (maybe there were three and I didn't realize 😞 )

@kaynnan kaynnan force-pushed the 16.0-mig-maintenance_product branch from bcdbe73 to ff3b432 Compare July 5, 2023 21:46
@kaynnan
Copy link
Contributor Author

kaynnan commented Jul 5, 2023

There is still two commits (maybe there were three and I didn't realize 😞 )

Sorry, typo here and the squash command didn't work, i now believe the history commit is correct, only pre-commit and migration

@etobella
Copy link
Member

etobella commented Jul 5, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-342-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 330c7b3 into OCA:16.0 Jul 5, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at baef436. Thanks a lot for contributing to OCA. ❤️

@kaynnan kaynnan deleted the 16.0-mig-maintenance_product branch July 13, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants