Fix mixed signed/unsigned comparisons and enforce size_t for object sizes in infer_shape #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
infer_shape
, variables holding tensor element counts were declared asint
/uint32_t
and compared against fields fromgeneric_param
. This caused:int
/uint32_t
for object sizes instead of the recommendedsize_t
.Importance
Related Standards:
Possible CWE Classification:
CWE-681: Incorrect Conversion between Numeric Types