Skip to content

Conversation

bzhang5
Copy link
Contributor

@bzhang5 bzhang5 commented Aug 20, 2021

No description provided.

Copy link
Collaborator

@kalcohol kalcohol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

options should keep

CMakeLists.txt Outdated
Comment on lines 52 to 53
OPTION (TENGINE_BUILD_BENCHMARK "Build benchmark" OFF)
OPTION (TENGINE_BUILD_EXAMPLES "Build examples" OFF)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPTION (TENGINE_BUILD_BENCHMARK "Build benchmark" OFF)
OPTION (TENGINE_BUILD_EXAMPLES "Build examples" OFF)
OPTION (TENGINE_BUILD_BENCHMARK "Build benchmark" ON)
OPTION (TENGINE_BUILD_EXAMPLES "Build examples" ON)

CMakeLists.txt Outdated
# Tools options
# Tools
OPTION (TENGINE_BUILD_CONVERT_TOOL "Build convert tool" OFF)
OPTION (TENGINE_BUILD_CONVERT_TOOL "Build convert tool" ON)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OPTION (TENGINE_BUILD_CONVERT_TOOL "Build convert tool" ON)
OPTION (TENGINE_BUILD_CONVERT_TOOL "Build convert tool" OFF)

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #1056 (532a1f9) into tengine-lite (6eba612) will decrease coverage by 2.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           tengine-lite    #1056      +/-   ##
================================================
- Coverage         47.72%   45.44%   -2.29%     
================================================
  Files               407        9     -398     
  Lines             29695     2577   -27118     
================================================
- Hits              14172     1171   -13001     
+ Misses            15523     1406   -14117     
Impacted Files Coverage Δ
source/operator/prototype/pooling_param.h 0.00% <0.00%> (-82.61%) ⬇️
tools/quantize/quant_tool_uint8.cpp 61.86% <0.00%> (-14.32%) ⬇️
source/device/cpu/op/permute/permute_ref.c
source/device/cpu/op/cast/cast_ref.c
source/device/cpu/op/normalize/normalize_ref.c
source/device/tim-vx/op/timvx_tanh.cc
source/device/cpu/op/lstm/lstm_ref.c
source/device/tim-vx/op/timvx_prelu.cc
source/device/tim-vx/op/timvx_sigmoid.cc
source/device/cpu/op/batchnorm/batchnorm_ref.c
... and 390 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eba612...532a1f9. Read the comment docs.

Copy link
Collaborator

@kalcohol kalcohol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalcohol kalcohol merged commit b265026 into OAID:tengine-lite Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants