Conversation
|
Looks good! This might be one to not put in aliases.nix for a while since it is almost everywhere. |
Package attrs should map to the pname. It's confusing otherwise. pkg-config is also the name used by most distributions: Debian, Homebrew, Guix, OpenSuse other distributions like FreeBSD ports, Fedora and Arch Linux call it "pkgconf" Waiting a few releases to make a tree-wide change to make it easier to back-port things.
2d8d67e to
bff5405
Compare
|
Ok, glad to see that I am not alone :) There are more packages that don't map 1:1 with their pname by the way. I think you are right, since pkg-config is used in the bootstrap, evaluation fails if it's in in the aliases.nix. |
|
Hmm, repology displays the same name for nixpkgs: https://repology.org/metapackage/pkg-config/versions Also a side note: pkgconf is a competing project that implements pkg-config command for compatibility. |
|
👍 for alias, one way or another. I think adding aliases is safe even for the stable branch, easing backports. I'm not really certain a mass replace is worth it, but this PR isn't really about that. |
|
Repology displays the "name" attribute, not the attribute name, so that's already "pkg-config". (uh, how would I better formulate that :) |
|
Evaluation fails if I move it into aliases.nix, probably because it's an input for the stdenv and aliases.nix only comes after the stdenv bootstrap. |
`etc/shell.nix`: Replace `pkgconfig` with `pkg-config` `pkgconfig` is [an old name][1] of `pkg-config` that has been [completely removed][2] in a recent version of nixpkgs. [1]: NixOS/nixpkgs#55094 [2]: NixOS/nixpkgs#192681 --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) --- - [ ] There are tests for these changes OR - [x] These changes do not require tests because they don't affect the production code
Package attrs should map to the pname. It's confusing otherwise.
pkg-config is also the name used by most distributions:
Debian, Homebrew, Guix, OpenSuse
other distributions like FreeBSD ports, Fedora and Arch Linux call it
"pkgconf"
Waiting a few releases to make a tree-wide change to make it easier to
back-port things.
Motivation for this change
I keep typing
pkg-configall the time.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)