Skip to content

llvmPackages.libllvm: fix enablePolly = false #444806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2025
Merged

llvmPackages.libllvm: fix enablePolly = false #444806

merged 2 commits into from
Sep 21, 2025
+11 −4

Conversation

LunNova
Copy link
Member

@LunNova LunNova commented Sep 21, 2025 •
edited
Loading

Setting enablePolly = false was failing due to trying to patch a file that doesn't exist

applying patch /nix/store/gr73nf6sca9nyzl88x58y3qxrav04yhd-polly-lit-cfg-add-libs-to-dylib-path.patch
can't find file to patch at input line 5

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LunNova
llvmPackages.libllvm: fix enablePolly = false
89baf53 
Setting enablePolly = false was failing due to trying to patch a file that doesn't exist

> applying patch /nix/store/gr73nf6sca9nyzl88x58y3qxrav04yhd-polly-lit-cfg-add-libs-to-dylib-path.patch
> can't find file to patch at input line 5
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels Sep 21, 2025
@LunNova
llvmPackages.libllvm: add passthru.tests.withoutOptionalFeatures
b842486 
This makes it easier to test optional flags still work.
Just adding one that disables multiple because the build is fairly slow and I don't think exercising
them all separately is going to be worth the extra build time.
@LunNova LunNova marked this pull request as ready for review September 21, 2025 00:39
@LunNova
Copy link
Member Author

LunNova commented Sep 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 444806 --package llvmPackages_21.libllvm.tests.withoutOptionalFeatures --package llvmPackages_20.libllvm.tests.withoutOptionalFeatures --package llvmPackages_19.libllvm.tests.withoutOptionalFeatures --package llvmPackages_18.libllvm.tests.withoutOptionalFeatures
Commit: b84248686baa595c7a34b64acd82d4c7d21555fc

x86_64-linux

✅ 16 packages built:
  • llvmPackages_18.libllvm.tests.withoutOptionalFeatures
  • llvmPackages_18.libllvm.tests.withoutOptionalFeatures.dev (llvmPackages_18.libllvm.tests.withoutOptionalFeatures.dev.dev, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.dev.lib, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.dev.python)
  • llvmPackages_18.libllvm.tests.withoutOptionalFeatures.lib (llvmPackages_18.libllvm.tests.withoutOptionalFeatures.lib.dev, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.lib.lib, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.lib.python)
  • llvmPackages_18.libllvm.tests.withoutOptionalFeatures.python (llvmPackages_18.libllvm.tests.withoutOptionalFeatures.python.dev, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.python.lib, llvmPackages_18.libllvm.tests.withoutOptionalFeatures.python.python)
  • llvmPackages_19.libllvm.tests.withoutOptionalFeatures
  • llvmPackages_19.libllvm.tests.withoutOptionalFeatures.dev (llvmPackages_19.libllvm.tests.withoutOptionalFeatures.dev.dev, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.dev.lib, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.dev.python)
  • llvmPackages_19.libllvm.tests.withoutOptionalFeatures.lib (llvmPackages_19.libllvm.tests.withoutOptionalFeatures.lib.dev, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.lib.lib, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.lib.python)
  • llvmPackages_19.libllvm.tests.withoutOptionalFeatures.python (llvmPackages_19.libllvm.tests.withoutOptionalFeatures.python.dev, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.python.lib, llvmPackages_19.libllvm.tests.withoutOptionalFeatures.python.python)
  • llvmPackages_20.libllvm.tests.withoutOptionalFeatures
  • llvmPackages_20.libllvm.tests.withoutOptionalFeatures.dev (llvmPackages_20.libllvm.tests.withoutOptionalFeatures.dev.dev, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.dev.lib, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.dev.python)
  • llvmPackages_20.libllvm.tests.withoutOptionalFeatures.lib (llvmPackages_20.libllvm.tests.withoutOptionalFeatures.lib.dev, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.lib.lib, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.lib.python)
  • llvmPackages_20.libllvm.tests.withoutOptionalFeatures.python (llvmPackages_20.libllvm.tests.withoutOptionalFeatures.python.dev, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.python.lib, llvmPackages_20.libllvm.tests.withoutOptionalFeatures.python.python)
  • llvmPackages_21.libllvm.tests.withoutOptionalFeatures
  • llvmPackages_21.libllvm.tests.withoutOptionalFeatures.dev (llvmPackages_21.libllvm.tests.withoutOptionalFeatures.dev.dev, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.dev.lib, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.dev.python)
  • llvmPackages_21.libllvm.tests.withoutOptionalFeatures.lib (llvmPackages_21.libllvm.tests.withoutOptionalFeatures.lib.dev, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.lib.lib, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.lib.python)
  • llvmPackages_21.libllvm.tests.withoutOptionalFeatures.python (llvmPackages_21.libllvm.tests.withoutOptionalFeatures.python.dev, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.python.lib, llvmPackages_21.libllvm.tests.withoutOptionalFeatures.python.python)

emilazy
emilazy approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Did I break this? I think I probably broke this.

FWIW I am in the middle of trying to kill this patch off in #430776. But this is certainly a necessary fix for now.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 21, 2025
@LunNova
Copy link
Member Author

LunNova commented Sep 21, 2025

Thanks. Did I break this? I think I probably broke this.

I think it's been wrong for a while and you just moved things around most recently, but it's a bit annoying to follow through some reformats and refactors so I didn't try to track this back to whenever it first broke.

@emilazy emilazy added this pull request to the merge queue Sep 21, 2025
Merged via the queue into NixOS:master with commit 9f1da93 Sep 21, 2025
33 of 37 checks passed
@LunNova LunNova deleted the lunnova/fix-enable-polly-false branch September 21, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@dtzWill dtzWill Awaiting requested review from dtzWill

@rrbutani rrbutani Awaiting requested review from rrbutani

@lovek323 lovek323 Awaiting requested review from lovek323

@alyssais alyssais Awaiting requested review from alyssais

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@RossComputerGuy RossComputerGuy Awaiting requested review from RossComputerGuy

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LunNova @emilazy