Skip to content

Conversation

mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Oct 26, 2024

Description of changes

magic-wormhole/magic-wormhole-transit-relay@refs/tags/0.2.1...refs/tags/0.3.1
magic-wormhole/magic-wormhole@refs/tags/0.16.0...refs/tags/0.17.0

nixpkgs-review result

tahoe-lafs is already broken on master

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

❌ 4 packages failed to build:
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info
✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.magic-wormhole-transit-relay.dist
  • python311Packages.magic-wormhole.dist
  • python312Packages.magic-wormhole-transit-relay
  • python312Packages.magic-wormhole-transit-relay.dist

aarch64-linux

❌ 4 packages failed to build:
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info
✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.magic-wormhole-transit-relay.dist
  • python311Packages.magic-wormhole.dist
  • python312Packages.magic-wormhole-transit-relay
  • python312Packages.magic-wormhole-transit-relay.dist

x86_64-darwin

✅ 8 packages built:
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.magic-wormhole-transit-relay.dist
  • python311Packages.magic-wormhole.dist
  • python312Packages.magic-wormhole-transit-relay
  • python312Packages.magic-wormhole-transit-relay.dist

aarch64-darwin

✅ 8 packages built:
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.magic-wormhole-transit-relay.dist
  • python311Packages.magic-wormhole.dist
  • python312Packages.magic-wormhole-transit-relay
  • python312Packages.magic-wormhole-transit-relay.dist

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 26, 2024
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 26, 2024
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tahoe-lafs was already broken on master.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351444


x86_64-linux

❌ 4 packages failed to build:
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info
✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.magic-wormhole-transit-relay.dist
  • python311Packages.magic-wormhole.dist
  • python312Packages.magic-wormhole-transit-relay
  • python312Packages.magic-wormhole-transit-relay.dist

@jopejoe1 jopejoe1 merged commit c63b724 into NixOS:master Nov 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants