Skip to content

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Jul 13, 2023

Description of changes

Makes building pkgsStatic.libnfc possible. I made it as part of static-haskell-nix.

Uses not-yet-merged patch from: nfc-tools/libnfc#595

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nh2 added a commit to nh2/nixpkgs that referenced this pull request Jul 13, 2023
@nh2
Copy link
Contributor Author

nh2 commented Jul 13, 2023

Found via: nh2/static-haskell-nix#116

@ofborg ofborg bot requested a review from offlinehacker July 13, 2023 20:22
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 13, 2023
teggotic pushed a commit to teggotic/nixpkgs that referenced this pull request Sep 17, 2023
u-quark pushed a commit to u-quark/nixpkgs that referenced this pull request Oct 23, 2023
@nh2
Copy link
Contributor Author

nh2 commented Jan 18, 2024

@offlinehacker Short ping regarding this small PR :)

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
nh2 added a commit to nh2/nixpkgs that referenced this pull request Jun 8, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 27, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 27, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants