Skip to content

various: add missing throw in alias and cleanup#227942

Merged
bobby285271 merged 7 commits intoNixOS:masterfrom
NickCao:alias
Apr 25, 2023
Merged

various: add missing throw in alias and cleanup#227942
bobby285271 merged 7 commits intoNixOS:masterfrom
NickCao:alias

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Apr 24, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member Author

NickCao commented Apr 24, 2023

Also: how often do we run maintainers/scripts/remove-old-aliases.py? Looks like aliases from 2020 and earlier are still here.

@NickCao NickCao changed the title various: add missing throw in alias various: add missing throw in alias and cleanup Apr 24, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 24, 2023
@bobby285271
Copy link
Member

how often do we run maintainers/scripts/remove-old-aliases.py?

Last run is #192681, which is later reverted in #196001 I think.

@bobby285271 bobby285271 merged commit 8cf9808 into NixOS:master Apr 25, 2023
@bobby285271
Copy link
Member

Okay I think cleaning throws marked with cleanup before xx.yy should be fine

@NickCao NickCao deleted the alias branch April 25, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants