refactor: SSE 이벤트를 recommend-result-created로 변경#121
Merged
Conversation
추천 결과 생성 완료 이벤트를 위한 새로운 스키마 정의 - accessKey, region, peopleCount, currentCount 필드 포함 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- gatheringFull.schema.ts 파일 삭제 - index.ts에서 recommendResultCreated 스키마로 export 변경 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
gathering-full 이벤트를 recommend-result-created로 변경 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
GATHERING_FULL 이벤트 스키마를 RECOMMEND_RESULT_CREATED로 교체 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- SSE 이벤트 리스너를 RECOMMEND_RESULT_CREATED로 변경 - 페이지 이동 딜레이 시간 단축 (2500ms → 2000ms) - startTime 변수 인라인화로 코드 간소화 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 추천 결과에 대한 Server-Sent Events(SSE) 시스템을 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
이 PR은 SSE 이벤트 시스템을 리팩토링하고, 페이지별 오류 처리 및 컴포넌트 구조를 대대적으로 개선하는 중요한 변경사항을 담고 있습니다. 폴링 방식에서 SSE 기반 실시간 업데이트로 전환하여 사용자 경험을 향상시킨 점과, error.tsx 및 not-found.tsx 파일을 추가하여 애플리케이션의 안정성을 높인 점이 인상적입니다. 또한, 페이지 및 기능 단위로 컴포넌트를 재구성하여 코드의 유지보수성을 크게 향상시켰습니다. 몇 가지 개선점을 제안드리며, 전반적으로 매우 훌륭한 리팩토링 작업이라고 생각합니다.
github-actions
bot
added
🔨 Refactor
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
## [2.0.0-beta.9](v2.0.0-beta.8...v2.0.0-beta.9) (2026-02-27) ### Code Refactoring * SSE 이벤트를 recommend-result-created로 변경 ([#121](#121)) ([222e613](222e613))
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
## [2.0.0](v1.5.1...v2.0.0) (2026-02-27) ### ⚠ BREAKING CHANGES * OpinionForm field names changed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * refactor: update schema field names and exports - foodCategorySchema → categorySchema - dislikedFoodSchema → dislikedCategoriesSchema - preferredMenusSchema → preferredCategoriesSchema - Update opinionFormSchema with new field names - Replace hardcoded "ANY" with CATEGORY.ANY * Schema field names changed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * refactor: rename component files to use Category naming - FoodCard → CategoryCard - FoodCategoryCarousel → CategoryCarousel - DislikedFoodButton → DislikedCategoryButton Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * refactor: update component export names - FoodCard → CategoryCard - FoodCategoryCarousel → CategoryCarousel - DislikedFoodButton → DislikedCategoryButton - Update component function names to match new file names - Internal logic unchanged (will be updated in next PR) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * refactor: update import references to use new constant names - Update all components to use new constant names: * RANKS → RANK_LIST * RANK_LABELS → RANK_LABEL * FOOD_CATEGORIES → CATEGORY_LIST * FOOD_CATEGORY_LABEL → CATEGORY_LABEL * FOOD_CATEGORY_VALUES → CATEGORY_VALUES * dislikedFoodSchema → dislikedCategoriesSchema * preferredMenusSchema → preferredCategoriesSchema - Update type imports: * FoodCategory → Category - Update form field references: * dislikedFoods → dislikedCategories * preferredMenus → preferredCategories - Fix component imports after file renames: * FoodCategoryCarousel → CategoryCarousel * DislikedFoodButton → DislikedCategoryButton This ensures the build succeeds after type system changes. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * style: run prettier format - Format code according to project prettier rules - No logic changes, only formatting Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> ### Features * 404, 500 에러 페이지 추가 ([#107](#107)) ([e9e5772](e9e5772)) * opinion 랜딩 페이지 UI 업데이트 (로고·lottie·footer) ([#120](#120)) ([2817c50](2817c50)) * SSE Event Registry 시스템 구현 및 마이그레이션 ([#119](#119)) ([178c79c](178c79c)) * SSE 기반 실시간 모임 현황 업데이트 구현 ([#87](#87)) ([0d220e0](0d220e0)) * 결과 페이지 - 투표 결과 섹션 구현 ([#106](#106)) ([c633225](c633225)) * 과반수 이상 의견 제출 시 추천 결과 생성 관련 API, Hook 추가 ([#103](#103)) ([5b31eec](5b31eec)), closes [#105](#105) * 인원 수 선택 시 시각적 피드백 추가 ([e9f6de6](e9f6de6)) * 추천 결과 API response 타입 업데이트 ([#100](#100)) ([1d046ab](1d046ab)), closes [#101](#101) [#102](#102) * 추천 결과 생성 대기 페이지 및 애니메이션 구현 ([#118](#118)) ([a720a76](a720a76)) * 취향 요약 카드 추가 ([#104](#104)) ([816fa96](816fa96)) ### Bug Fixes * 1, 3순위를 선택했으나 2순위를 선택하지 않았을 경우 Validation 을 막지 않았던 문제 수정 ([#113](#113)) ([22e58e8](22e58e8)) * GitHub Actions 워크플로우 개선 및 스타일 가이드 업데이트 ([#91](#91)) ([e6c009e](e6c009e)) * 결과 대기 페이지 내 공유 버튼 스타일을 Tertiary 로 수정 ([#115](#115)) ([a63ddd1](a63ddd1)) * 결과 페이지 - 상단 취향 요약 섹션, 하단 투표 결과 선호 카테고리 노출 순서 로직 수정 ([#117](#117)) ([f5c4a1c](f5c4a1c)) * 모임 인원 초과 및 결과 생성 완료 시 Toast 커스텀 기능 추가 ([#116](#116)) ([6088935](6088935)) * 음식 카테고리 일러스트레이터를 Figma 내 최신 시안으로 수정 ([#114](#114)) ([18f9cc3](18f9cc3)) ### Code Refactoring * opinion 페이지 컴포넌트 구조 개선 및 로직 통합 ([#109](#109)) ([a76f75f](a76f75f)) * PeopleIllustration 캐릭터 배치 및 구조 개선 ([#112](#112)) ([ae95b72](ae95b72)) * ProgressBar 컴포넌트 UI 개선 및 코드 최적화 ([#122](#122)) ([c73de1d](c73de1d)) * SSE 이벤트를 recommend-result-created로 변경 ([#121](#121)) ([222e613](222e613)) * 타입 시스템 리팩토링 - enum을 as const 패턴으로 전환 ([#110](#110)) ([d427378](d427378)), closes [#111](#111)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 PR 제목
refactor: SSE 이벤트를 recommend-result-created로 변경
📑 작업 상세 내역
기능 추가
리팩토링
🙏 리뷰 요청 사항
📃 참고 자료
src/schemas/sse/recommendResultCreated.schema.ts(추가)src/schemas/sse/gatheringFull.schema.ts(삭제)src/schemas/sse/index.tssrc/hooks/sse/types.tssrc/hooks/sse/schemas.tssrc/hooks/gathering/useProceedRecommendResult.ts🖼️ 작업 결과물
recommend-result-created이벤트로 정상적으로 동작합니다